From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035414AbcIWQHK (ORCPT ); Fri, 23 Sep 2016 12:07:10 -0400 Received: from foss.arm.com ([217.140.101.70]:36058 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030326AbcIWQHJ (ORCPT ); Fri, 23 Sep 2016 12:07:09 -0400 Date: Fri, 23 Sep 2016 17:07:11 +0100 From: Will Deacon To: Punit Agrawal Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Mark Rutland , Christoffer Dall , Marc Zyngier , Steven Rostedt , Ingo Molnar , Catalin Marinas Subject: Re: [PATCH 4/7] arm64: tlbflush.h: add __tlbi() macro Message-ID: <20160923160710.GF6397@arm.com> References: <1473761769-30572-1-git-send-email-punit.agrawal@arm.com> <1473761769-30572-5-git-send-email-punit.agrawal@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473761769-30572-5-git-send-email-punit.agrawal@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2016 at 11:16:06AM +0100, Punit Agrawal wrote: > From: Mark Rutland > > As with dsb() and isb(), add a __tlbi() helper so that we can avoid > distracting asm boilerplate every time we want a TLBI. As some TLBI > operations take an argument while others do not, some pre-processor is > used to handle these two cases with different assembly blocks. > > The existing tlbflush.h code is moved over to use the helper. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Marc Zyngier > [ rename helper to __tlbi, update comment and commit log ] > Signed-off-by: Punit Agrawal > Reviewed-by: Will Deacon > --- > arch/arm64/include/asm/tlbflush.h | 34 ++++++++++++++++++++++++++-------- > 1 file changed, 26 insertions(+), 8 deletions(-) Given that this series seems to have stalled, I'm inclined to pick this patch (and only this patch) up in the arm64 tree. It's a standalone tidy up and means one fewer dependency next time round. Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH 4/7] arm64: tlbflush.h: add __tlbi() macro Date: Fri, 23 Sep 2016 17:07:11 +0100 Message-ID: <20160923160710.GF6397@arm.com> References: <1473761769-30572-1-git-send-email-punit.agrawal@arm.com> <1473761769-30572-5-git-send-email-punit.agrawal@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marc Zyngier , Catalin Marinas , linux-kernel@vger.kernel.org, Steven Rostedt , Ingo Molnar , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org To: Punit Agrawal Return-path: Content-Disposition: inline In-Reply-To: <1473761769-30572-5-git-send-email-punit.agrawal@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org On Tue, Sep 13, 2016 at 11:16:06AM +0100, Punit Agrawal wrote: > From: Mark Rutland > > As with dsb() and isb(), add a __tlbi() helper so that we can avoid > distracting asm boilerplate every time we want a TLBI. As some TLBI > operations take an argument while others do not, some pre-processor is > used to handle these two cases with different assembly blocks. > > The existing tlbflush.h code is moved over to use the helper. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Marc Zyngier > [ rename helper to __tlbi, update comment and commit log ] > Signed-off-by: Punit Agrawal > Reviewed-by: Will Deacon > --- > arch/arm64/include/asm/tlbflush.h | 34 ++++++++++++++++++++++++++-------- > 1 file changed, 26 insertions(+), 8 deletions(-) Given that this series seems to have stalled, I'm inclined to pick this patch (and only this patch) up in the arm64 tree. It's a standalone tidy up and means one fewer dependency next time round. Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Fri, 23 Sep 2016 17:07:11 +0100 Subject: [PATCH 4/7] arm64: tlbflush.h: add __tlbi() macro In-Reply-To: <1473761769-30572-5-git-send-email-punit.agrawal@arm.com> References: <1473761769-30572-1-git-send-email-punit.agrawal@arm.com> <1473761769-30572-5-git-send-email-punit.agrawal@arm.com> Message-ID: <20160923160710.GF6397@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 13, 2016 at 11:16:06AM +0100, Punit Agrawal wrote: > From: Mark Rutland > > As with dsb() and isb(), add a __tlbi() helper so that we can avoid > distracting asm boilerplate every time we want a TLBI. As some TLBI > operations take an argument while others do not, some pre-processor is > used to handle these two cases with different assembly blocks. > > The existing tlbflush.h code is moved over to use the helper. > > Signed-off-by: Mark Rutland > Cc: Catalin Marinas > Cc: Marc Zyngier > [ rename helper to __tlbi, update comment and commit log ] > Signed-off-by: Punit Agrawal > Reviewed-by: Will Deacon > --- > arch/arm64/include/asm/tlbflush.h | 34 ++++++++++++++++++++++++++-------- > 1 file changed, 26 insertions(+), 8 deletions(-) Given that this series seems to have stalled, I'm inclined to pick this patch (and only this patch) up in the arm64 tree. It's a standalone tidy up and means one fewer dependency next time round. Will