From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boQxz-0002my-WA for qemu-devel@nongnu.org; Mon, 26 Sep 2016 04:08:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boQxz-0005SM-3F for qemu-devel@nongnu.org; Mon, 26 Sep 2016 04:08:47 -0400 Received: from mail.ispras.ru ([83.149.199.45]:49614) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boQxy-0005Qb-Ra for qemu-devel@nongnu.org; Mon, 26 Sep 2016 04:08:47 -0400 From: Pavel Dovgalyuk Date: Mon, 26 Sep 2016 11:08:38 +0300 Message-ID: <20160926080838.6992.95614.stgit@PASHA-ISP> In-Reply-To: <20160926080757.6992.74311.stgit@PASHA-ISP> References: <20160926080757.6992.74311.stgit@PASHA-ISP> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org, quintela@redhat.com, jasowang@redhat.com, mst@redhat.com, pbonzini@redhat.com This patch disables snapshotting for block driver filters. It is needed, because snapshots should be created in underlying disk images, not in filters itself. Signed-off-by: Pavel Dovgalyuk --- block/snapshot.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/snapshot.c b/block/snapshot.c index bf5c2ca..8998b8b 100644 --- a/block/snapshot.c +++ b/block/snapshot.c @@ -184,6 +184,9 @@ int bdrv_snapshot_goto(BlockDriverState *bs, if (!drv) { return -ENOMEDIUM; } + if (drv->is_filter) { + return 0; + } if (drv->bdrv_snapshot_goto) { return drv->bdrv_snapshot_goto(bs, snapshot_id); }