From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966112AbcIZI4e (ORCPT <rfc822;w@1wt.eu>);
        Mon, 26 Sep 2016 04:56:34 -0400
Received: from exsmtp03.microchip.com ([198.175.253.49]:62466 "EHLO
        email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S966041AbcIZI4c (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Sep 2016 04:56:32 -0400
Date: Mon, 26 Sep 2016 10:56:06 +0200
From: Christian Gromm <christian.gromm@microchip.com>
To: Wei Yongjun <weiyj.lk@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Andrey Shvetsov <andrey.shvetsov@k2l.de>,
        Shraddha Barke <shraddha.6596@gmail.com>,
        Wei Yongjun <weiyongjun1@huawei.com>, <devel@driverdev.osuosl.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] staging: most: fix error return code in
 audio_probe_channel()
Message-ID: <20160926105606.4d4033be@muaddib>
In-Reply-To: <20160926074718.GA456@KAR-DK-M21181.mchp-main.com>
References: <1474818071-18972-1-git-send-email-weiyj.lk@gmail.com>
        <20160926074718.GA456@KAR-DK-M21181.mchp-main.com>
Organization: MCHP
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 26 Sep 2016 09:47:19 +0200
Andrey Shvetsov <andrey.shvetsov@k2l.de> wrote:

> On Sun, Sep 25, 2016 at 03:41:11PM +0000, Wei Yongjun wrote:
> > From: Wei Yongjun <weiyongjun1@huawei.com>
> > 
> > Fix to return a negative error code from the audio_set_hw_params() error
> > handling case instead of 0, as done elsewhere in this function.
> > 
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>

> 
> > ---
> >  drivers/staging/most/aim-sound/sound.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c
> > index 3dc625c..00f01c9 100644
> > --- a/drivers/staging/most/aim-sound/sound.c
> > +++ b/drivers/staging/most/aim-sound/sound.c
> > @@ -607,7 +607,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id,
> >  	channel->id = channel_id;
> >  	init_waitqueue_head(&channel->playback_waitq);
> >  
> > -	if (audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg))
> > +	ret = audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg);
> > +	if (ret)
> >  		goto err_free_card;
> >  
> >  	snprintf(card->driver, sizeof(card->driver), "%s", DRIVER_NAME);
> > 
>