From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751449AbcI0Dzf (ORCPT ); Mon, 26 Sep 2016 23:55:35 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:47186 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbcI0DzY (ORCPT ); Mon, 26 Sep 2016 23:55:24 -0400 Date: Tue, 27 Sep 2016 04:55:22 +0100 From: Al Viro To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/11] splice cleanups Message-ID: <20160927035522.GJ19539@ZenIV.linux.org.uk> References: <1473842236-28655-1-git-send-email-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473842236-28655-1-git-send-email-mszeredi@redhat.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 10:37:05AM +0200, Miklos Szeredi wrote: > This contains assorted cleanups in the splice area: > > - add helpers for pipe buf ops instead of directly calling them > > - page cache buf doesn't seem to need confirming (since ages) > > - generic_file_splice_read() and generic_file_read() have lots of > duplication > > Git tree is here: > > git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git#splice My apologies for not replying back when it had been first posted, especially since I'd been actively messing with splice-related code at that time (it started in "xfs_file_splice_read: possible circular locking dependency detected" thread on xfs list). I've no objections against your inline helpers. I'm not so sure about ->confirm() and I really think that __generic_file_splice_read() should simply die. Could you rebase the beginning of that thing on top of #work.splice_read in vfs.git?