From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39593)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1borYb-0003pL-E1
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 08:32:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1borYV-00040E-Rz
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 08:32:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49864)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1borYV-0003zw-Lx
	for qemu-devel@nongnu.org; Tue, 27 Sep 2016 08:32:15 -0400
Date: Tue, 27 Sep 2016 20:32:11 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160927123211.GB11892@lemon>
References: <1474976917-102710-1-git-send-email-borntraeger@de.ibm.com>
	<1474976917-102710-9-git-send-email-borntraeger@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1474976917-102710-9-git-send-email-borntraeger@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 8/8] s390x/kvm: fix build against qemu_uuid
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Cornelia Huck <cornelia.huck@de.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Alexander Graf <agraf@suse.de>

On Tue, 09/27 13:48, Christian Borntraeger wrote:
> commit 9c5ce8db2e5c ("vl: Switch qemu_uuid to QemuUUID") changed most
> users of qemu_uuid but not all. Fix a build error on s390/kvm.
> 
> Cc: Fam Zheng <famz@redhat.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target-s390x/kvm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
> index a95d3da..495905c 100644
> --- a/target-s390x/kvm.c
> +++ b/target-s390x/kvm.c
> @@ -1999,7 +1999,7 @@ static void insert_stsi_3_2_2(S390CPU *cpu, __u64 addr, uint8_t ar)
>          strcpy((char *)sysib.ext_names[0], "KVMguest");
>      }
>      /* Insert UUID */
> -    memcpy(sysib.vm[0].uuid, qemu_uuid, sizeof(sysib.vm[0].uuid));
> +    memcpy(sysib.vm[0].uuid, &qemu_uuid, sizeof(sysib.vm[0].uuid));
>  
>      s390_cpu_virt_mem_write(cpu, addr, ar, &sysib, sizeof(sysib));
>  }
> -- 
> 2.5.5
> 

Reviewed-by: Fam Zheng <famz@redhat.com>