All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: zenczykowski@gmail.com
Cc: maze@google.com, netdev@vger.kernel.org, ek@google.com,
	lorenzo@google.com, hannes@stressinduktion.org
Subject: Re: [PATCH] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl
Date: Wed, 28 Sep 2016 07:49:01 -0400 (EDT)	[thread overview]
Message-ID: <20160928.074901.901607987499248966.davem@davemloft.net> (raw)
In-Reply-To: <1474978605-28116-1-git-send-email-zenczykowski@gmail.com>

From: Maciej Żenczykowski <zenczykowski@gmail.com>
Date: Tue, 27 Sep 2016 05:16:45 -0700

> From: Maciej Żenczykowski <maze@google.com>
> 
> Signed-off-by: Maciej Żenczykowski <maze@google.com>

I was about to ask you to submit this patch alongside an actual
addition of a proc_dointvec_minmax user to the table.

But upon second checking there is one, indirectly via
addrconf_sysctl_mtu().

I should never have to search and figure things out like that.  It
should be obvious or explained in the commit message.

You must explain in detail what the dependency is, why you
have to make this change, how you made it, and why you made
it that way.

Especially in this case, your empty commit message is really
not appropriate.

Thanks.

  reply	other threads:[~2016-09-28 11:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27 12:16 [PATCH] ipv6 addrconf: enable use of proc_dointvec_minmax in addrconf_sysctl Maciej Żenczykowski
2016-09-28 11:49 ` David Miller [this message]
2016-09-28 11:52   ` David Miller
     [not found]     ` <CAHo-Oowk-YN2bHkWWKe_yAWsXQtybu3CZ+beXTiAO9914vouyg@mail.gmail.com>
2016-09-28 15:21       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160928.074901.901607987499248966.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ek@google.com \
    --cc=hannes@stressinduktion.org \
    --cc=lorenzo@google.com \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=zenczykowski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.