From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1bpAX4-0003mu-Lc
	for qemu-devel@nongnu.org; Wed, 28 Sep 2016 04:48:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1bpAX1-0004D1-IN
	for qemu-devel@nongnu.org; Wed, 28 Sep 2016 04:48:02 -0400
Received: from 20.mo5.mail-out.ovh.net ([91.121.55.239]:50901)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <groug@kaod.org>) id 1bpAX1-0004Ck-CQ
	for qemu-devel@nongnu.org; Wed, 28 Sep 2016 04:47:59 -0400
Received: from player799.ha.ovh.net (b9.ovh.net [213.186.33.59])
	by mo5.mail-out.ovh.net (Postfix) with ESMTP id 52C80FCA4
	for <qemu-devel@nongnu.org>; Wed, 28 Sep 2016 10:47:58 +0200 (CEST)
Date: Wed, 28 Sep 2016 10:47:52 +0200
From: Greg Kurz <groug@kaod.org>
Message-ID: <20160928104752.2772cbce@bahia>
In-Reply-To: <CAKXe6SKvd7Y9bS16SVBt8x+jUD1EZO=izSnqC8NJMtcd5qB-ZA@mail.gmail.com>
References: <57e9f923.05acca0a.3dec3.0ccc@mx.google.com>
	<CAKXe6SKvd7Y9bS16SVBt8x+jUD1EZO=izSnqC8NJMtcd5qB-ZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] 9pfs: fix information leak in xattr read
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Li Qiang <liq3ea@gmail.com>
Cc: aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org, Li Qiang <liqiang6-s@360.cn>

On Wed, 28 Sep 2016 14:42:05 +0800
Li Qiang <liq3ea@gmail.com> wrote:

> Hi Greg,
> 
> What about this patch?
> 
> It seems you have forget it.
> 

Heh not exactly... I'm just wondering why we allocate xattr_fidp->fs.xattr.value
here if we don't use it. Can you please investigate if it is possible to defer
allocation until it is really needed ?

Thanks.

--
Greg

> 2016-09-27 12:44 GMT+08:00 Li Qiang <liq3ea@gmail.com>:
> 
> > From: Li Qiang <liqiang6-s@360.cn>
> >
> > 9pfs uses g_malloc() to allocate the xattr memory space, if the guest
> > reads this memory before writing to it, this will leak host heap
> > memory to the guest. This patch avoid this.
> >
> > Signed-off-by: Li Qiang <liqiang6-s@360.cn>
> > ---
> >  hw/9pfs/9p.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> > index b1ff8e7..4db1bd8 100644
> > --- a/hw/9pfs/9p.c
> > +++ b/hw/9pfs/9p.c
> > @@ -3291,7 +3291,7 @@ static void v9fs_xattrcreate(void *opaque)
> >      xattr_fidp->fs.xattr.flags = flags;
> >      v9fs_string_init(&xattr_fidp->fs.xattr.name);
> >      v9fs_string_copy(&xattr_fidp->fs.xattr.name, &name);
> > -    xattr_fidp->fs.xattr.value = g_malloc(size);
> > +    xattr_fidp->fs.xattr.value = g_malloc0(size);
> >      err = offset;
> >      put_fid(pdu, file_fidp);
> >  out_nofid:
> > --
> > 1.8.3.1
> >
> >