From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpDAC-0001UA-L8 for qemu-devel@nongnu.org; Wed, 28 Sep 2016 07:36:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpDA8-0000oh-LB for qemu-devel@nongnu.org; Wed, 28 Sep 2016 07:36:36 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:32888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpDA8-0000o6-DS for qemu-devel@nongnu.org; Wed, 28 Sep 2016 07:36:32 -0400 Received: by mail-wm0-x243.google.com with SMTP id w84so5499026wmg.0 for ; Wed, 28 Sep 2016 04:36:32 -0700 (PDT) Date: Wed, 28 Sep 2016 12:36:30 +0100 From: Stefan Hajnoczi Message-ID: <20160928113630.GA18888@stefanha-x1.localdomain> References: <1475035789-685-1-git-send-email-ashish.mittal@veritas.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline In-Reply-To: <1475035789-685-1-git-send-email-ashish.mittal@veritas.com> Subject: Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashish Mittal Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, kwolf@redhat.com, armbru@redhat.com, berrange@redhat.com, jcody@redhat.com, famz@redhat.com, ashish.mittal@veritas.com, Ketan.Nilangekar@veritas.com, Abhijit.Dey@veritas.com --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 27, 2016 at 09:09:49PM -0700, Ashish Mittal wrote: > This patch adds support for a new block device type called "vxhs". > Source code for the library that this code loads can be downloaded from: > https://github.com/MittalAshish/libqnio.git >=20 > Sample command line using JSON syntax: > ./qemu-system-x86_64 -name instance-00000008 -S -vnc 0.0.0.0:0 -k en-us -= vga cirrus -device virtio-balloon-pci,id=3Dballoon0,bus=3Dpci.0,addr=3D0x5 = -msg timestamp=3Don 'json:{"driver":"vxhs","vdisk_id":"{c3e9095a-a5ee-4dce-= afeb-2a59fb387410}","server":[{"host":"172.172.17.4","port":"9999"},{"host"= :"172.172.17.2","port":"9999"}]}' >=20 > Sample command line using URI syntax: > qemu-img convert -f raw -O raw -n /var/lib/nova/instances/_base/0c5eacd5e= bea5ed914b6a3e7b18f1ce734c386ad vxhs://192.168.0.1:9999/%7Bc6718f6b-0401-44= 1d-a8c3-1f0064d75ee0%7D >=20 > Signed-off-by: Ashish Mittal Have you tried running the qemu-iotests test suite? http://qemu-project.org/Documentation/QemuIoTests The test suite needs to be working in order for this block driver to be merged. Please also consider how to test failover. You can use blkdebug (see docs/blkdebug.txt) to inject I/O errors but perhaps you need something more low-level in the library. --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJX66s+AAoJEJykq7OBq3PIbw4H/3MsVTZKQuWozjxTiFKeXUvh l7NMVkOtm9aA9Dr8rDTLumqgf9iEM3u7tZ3HmGghFEzObNosrLPy5gkmBQKI4guR k7JvR7vHWixATVJ7nhyihNEU8rmq3F7N3oQGldqqFaclozBqtFmf79nysAXPYwAj hW/baRIfXMVexV5f9O5SNHxeKYaUZE4Ef4dbTkMyHebhYvRdKdKyFTlgI9IUOZxq w1QrthvWilHfvAkQyqaiYcBH7EjuaW6jvWZ1E68Ek5Y3Si5nxCyIGk8yKH/bdmpn 4em2nIrZzyfHckcNJyT8g9fWvygX8DfkNzGgzWAeLV2vVqPdw4U413ZoFWANaTE= =Y6Ln -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV--