From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv2] usb: musb: Fix unbalanced platform_disable Date: Wed, 28 Sep 2016 11:42:35 -0700 Message-ID: <20160928184234.zoleas3mvpxso36r@atomide.com> References: <20160912153947.k4gnggur6usyujii@atomide.com> <2377851.ZR7UYeyr7h@avalon> <20160919224149.3msqxiv24ofwjz4c@atomide.com> <1688038.txo7nUYeUv@avalon> <20160920171024.mnfjelzxjgv7s7dv@atomide.com> <20160920183701.nxme7yxgc6jpmgio@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160920183701.nxme7yxgc6jpmgio-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laurent Pinchart Cc: Bin Liu , Greg Kroah-Hartman , Kishon Vijay Abraham I , Andreas Kemnade , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org * Tony Lindgren [160920 11:37]: > * Tony Lindgren [160920 10:11]: > > * Laurent Pinchart [160919 23:36]: > > > No, I perform the following steps: > > > > > > - Connect the panda board to the USB through USB (which powers the board on) > > > - Let the board boot over NFS > > > - Log in as root, run 'reboot' > > > > > > The second boot produces the warning. > > > > Oh I was looking at the errors while shutting down things.. OK yeah I get > > that too along with a bunch of DSS related warnings with your .config. > > Probably I did not notice it earlier because of the DSS warnings. Will > > take a look. > > The patch below fixes the issue for me, care to give it a try? > > If that works for you I'll repost with a proper patch description. Laurent, any news on when you may be able to test this one? Regards, Tony > 8< ------------------------ > diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c > --- a/drivers/usb/musb/musb_gadget.c > +++ b/drivers/usb/musb/musb_gadget.c > @@ -1255,6 +1255,7 @@ static int musb_gadget_queue(struct usb_ep *ep, struct usb_request *req, > > map_dma_buffer(request, musb, musb_ep); > > + pm_runtime_get_sync(musb->controller); > spin_lock_irqsave(&musb->lock, lockflags); > > /* don't queue if the ep is down */ > @@ -1275,6 +1276,9 @@ static int musb_gadget_queue(struct usb_ep *ep, struct usb_request *req, > > unlock: > spin_unlock_irqrestore(&musb->lock, lockflags); > + pm_runtime_mark_last_busy(musb->controller); > + pm_runtime_put_autosuspend(musb->controller); > + > return status; > } > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html