All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Sascha Silbe <silbe@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH v4 2/3] iotests: Remove raciness from 162
Date: Wed, 28 Sep 2016 22:46:43 +0200	[thread overview]
Message-ID: <20160928204644.11523-3-mreitz@redhat.com> (raw)
In-Reply-To: <20160928204644.11523-1-mreitz@redhat.com>

With qemu-nbd's new --fork option, we no longer need to launch it the
hacky way.

Suggested-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/162 | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/qemu-iotests/162 b/tests/qemu-iotests/162
index 0b43ea3..c7e6593 100755
--- a/tests/qemu-iotests/162
+++ b/tests/qemu-iotests/162
@@ -51,8 +51,7 @@ $QEMU_IMG info 'json:{"driver": "nbd", "host": "does.not.exist.example.com", "po
 # This is a test for NBD's bdrv_refresh_filename() implementation: It expects
 # either host or path to be set, but it must not assume that they are set to
 # strings in the options QDict
-$QEMU_NBD -k "$PWD/42" -f raw null-co:// &
-sleep 0.5
+$QEMU_NBD -k "$PWD/42" -f raw --fork null-co://
 $QEMU_IMG info 'json:{"driver": "nbd", "path": 42}' | grep '^image'
 rm -f 42
 
-- 
2.10.0

  parent reply	other threads:[~2016-09-28 20:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 20:46 [Qemu-devel] [PATCH v4 0/3] iotests: Fix test 162 Max Reitz
2016-09-28 20:46 ` [Qemu-devel] [PATCH v4 1/3] qemu-nbd: Add --fork option Max Reitz
2016-09-28 20:46 ` Max Reitz [this message]
2016-09-28 20:46 ` [Qemu-devel] [PATCH v4 3/3] iotests: Do not rely on unavailable domains in 162 Max Reitz
2016-10-12  8:55 ` [Qemu-devel] [Qemu-block] [PATCH v4 0/3] iotests: Fix test 162 Hao QingFeng
2016-10-12 19:46   ` Max Reitz
2016-10-13  5:20     ` Hao QingFeng
2016-10-15 17:27       ` Max Reitz
2016-10-24  6:23         ` Hao QingFeng
2016-10-17 17:07 ` [Qemu-devel] " Max Reitz
2016-10-18  9:36   ` Kevin Wolf
2016-10-24 14:30     ` [Qemu-devel] [Qemu-block] " Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160928204644.11523-3-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=silbe@linux.vnet.ibm.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.