From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH v4 12/12] iotests: Add test for NBD's blockdev-add interface
Date: Wed, 28 Sep 2016 22:56:02 +0200 [thread overview]
Message-ID: <20160928205602.17275-13-mreitz@redhat.com> (raw)
In-Reply-To: <20160928205602.17275-1-mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/147 | 201 +++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/147.out | 5 ++
tests/qemu-iotests/group | 1 +
3 files changed, 207 insertions(+)
create mode 100755 tests/qemu-iotests/147
create mode 100644 tests/qemu-iotests/147.out
diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotests/147
new file mode 100755
index 0000000..61e1e6f
--- /dev/null
+++ b/tests/qemu-iotests/147
@@ -0,0 +1,201 @@
+#!/usr/bin/env python
+#
+# Test case for NBD's blockdev-add interface
+#
+# Copyright (C) 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+
+import os
+import socket
+import stat
+import time
+import iotests
+from iotests import cachemode, imgfmt, qemu_img, qemu_nbd
+
+NBD_PORT = 10811
+
+test_img = os.path.join(iotests.test_dir, 'test.img')
+
+class NBDBlockdevAddBase(iotests.QMPTestCase):
+ def blockdev_add_options(self, address, export=None):
+ options = { 'node-name': 'nbd-blockdev',
+ 'driver': 'raw',
+ 'file': {
+ 'driver': 'nbd',
+ 'address': address
+ } }
+ if export is not None:
+ options['file']['export'] = export
+ return options
+
+ def client_test(self, filename, address, export=None):
+ bao = self.blockdev_add_options(address, export)
+ result = self.vm.qmp('blockdev-add', options=bao)
+ self.assert_qmp(result, 'return', {})
+
+ result = self.vm.qmp('query-named-block-nodes')
+ for node in result['return']:
+ if node['node-name'] == 'nbd-blockdev':
+ self.assert_qmp(node, 'image/filename', filename)
+ break
+
+ result = self.vm.qmp('x-blockdev-del', node_name='nbd-blockdev')
+ self.assert_qmp(result, 'return', {})
+
+
+class QemuNBD(NBDBlockdevAddBase):
+ def setUp(self):
+ qemu_img('create', '-f', iotests.imgfmt, test_img, '64k')
+ self.vm = iotests.VM()
+ self.vm.launch()
+
+ def tearDown(self):
+ self.vm.shutdown()
+ os.remove(test_img)
+
+ def _server_up(self, *args):
+ self.assertEqual(qemu_nbd('-f', imgfmt, test_img, *args), 0)
+
+ def test_inet(self):
+ self._server_up('-p', str(NBD_PORT))
+ address = { 'type': 'inet',
+ 'data': {
+ 'host': 'localhost',
+ 'port': str(NBD_PORT)
+ } }
+ self.client_test('nbd://localhost:%i' % NBD_PORT, address)
+
+ def test_unix(self):
+ socket = os.path.join(iotests.test_dir, 'qemu-nbd.socket')
+ self._server_up('-k', socket)
+ address = { 'type': 'unix',
+ 'data': { 'path': socket } }
+ self.client_test('nbd+unix://?socket=' + socket, address)
+ try:
+ os.remove(socket)
+ except OSError:
+ pass
+
+
+class BuiltinNBD(NBDBlockdevAddBase):
+ def setUp(self):
+ qemu_img('create', '-f', iotests.imgfmt, test_img, '64k')
+ self.vm = iotests.VM()
+ self.vm.launch()
+ self.server = iotests.VM('.server')
+ self.server.add_drive_raw('if=none,id=nbd-export,' +
+ 'file=%s,' % test_img +
+ 'format=%s,' % imgfmt +
+ 'cache=%s' % cachemode)
+ self.server.launch()
+
+ def tearDown(self):
+ self.vm.shutdown()
+ self.server.shutdown()
+ os.remove(test_img)
+
+ def _server_up(self, address):
+ result = self.server.qmp('nbd-server-start', addr=address)
+ self.assert_qmp(result, 'return', {})
+
+ result = self.server.qmp('nbd-server-add', device='nbd-export')
+ self.assert_qmp(result, 'return', {})
+
+ def _server_down(self):
+ result = self.server.qmp('nbd-server-stop')
+ self.assert_qmp(result, 'return', {})
+
+ def test_inet(self):
+ address = { 'type': 'inet',
+ 'data': {
+ 'host': 'localhost',
+ 'port': str(NBD_PORT)
+ } }
+ self._server_up(address)
+ self.client_test('nbd://localhost:%i/nbd-export' % NBD_PORT,
+ address, 'nbd-export')
+ self._server_down()
+
+ def test_inet6(self):
+ address = { 'type': 'inet',
+ 'data': {
+ 'host': '::1',
+ 'port': str(NBD_PORT),
+ 'ipv4': False,
+ 'ipv6': True
+ } }
+ filename = 'json:{"driver": "raw", ' + \
+ '"file": {"driver": "nbd", ' + \
+ '"address.data.host": "::1", ' + \
+ '"address.data.ipv4": false, ' + \
+ '"address.data.ipv6": true, ' + \
+ '"address.type": "inet", ' + \
+ '"export": "nbd-export", ' + \
+ '"address.data.port": "%i"}}' % NBD_PORT
+ self._server_up(address)
+ self.client_test(filename, address, 'nbd-export')
+ self._server_down()
+
+ def test_unix(self):
+ socket = os.path.join(iotests.test_dir, 'nbd.socket')
+ address = { 'type': 'unix',
+ 'data': { 'path': socket } }
+ self._server_up(address)
+ self.client_test('nbd+unix:///nbd-export?socket=' + socket,
+ address, 'nbd-export')
+ self._server_down()
+ try:
+ os.remove(socket)
+ except OSError:
+ pass
+
+ def test_fd(self):
+ sockfile = os.path.join(iotests.test_dir, 'nbd.socket')
+ self._server_up({ 'type': 'unix',
+ 'data': { 'path': sockfile } })
+
+ sockfd = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
+ sockfd.connect(sockfile)
+
+ result = self.vm.send_fd_scm(str(sockfd.fileno()))
+ self.assertEqual(result, 0, 'Failed to send socket FD')
+
+ result = self.vm.qmp('getfd', fdname='nbd-fifo')
+ self.assert_qmp(result, 'return', {})
+
+ filename = 'json:{"driver": "raw", ' + \
+ '"file": {"driver": "nbd", ' + \
+ '"address.type": "fd", ' + \
+ '"export": "nbd-export", ' + \
+ '"address.data.str": "nbd-fifo"}}'
+ self.client_test(filename,
+ { 'type': 'fd',
+ 'data': { 'str': 'nbd-fifo' } },
+ 'nbd-export')
+
+ self._server_down()
+
+ try:
+ os.remove(sockfile)
+ except OSError:
+ pass
+
+
+if __name__ == '__main__':
+ # Need to support image creation
+ iotests.main(supported_fmts=['vpc', 'parallels', 'qcow', 'vdi', 'qcow2',
+ 'vmdk', 'raw', 'vhdx', 'qed'])
+
diff --git a/tests/qemu-iotests/147.out b/tests/qemu-iotests/147.out
new file mode 100644
index 0000000..3f8a935
--- /dev/null
+++ b/tests/qemu-iotests/147.out
@@ -0,0 +1,5 @@
+......
+----------------------------------------------------------------------
+Ran 6 tests
+
+OK
diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
index 7eb1770..d7d50cf 100644
--- a/tests/qemu-iotests/group
+++ b/tests/qemu-iotests/group
@@ -149,6 +149,7 @@
144 rw auto quick
145 auto quick
146 auto quick
+147 auto
148 rw auto quick
149 rw auto sudo
150 rw auto quick
--
2.10.0
next prev parent reply other threads:[~2016-09-28 20:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 20:55 [Qemu-devel] [PATCH v4 00/12] qapi: Allow blockdev-add for NBD Max Reitz
2016-09-28 20:55 ` [Qemu-devel] [PATCH v4 01/12] block/nbd: Drop trailing "." in error messages Max Reitz
2016-09-30 17:40 ` Eric Blake
2016-10-13 11:34 ` Kevin Wolf
2016-09-28 20:55 ` [Qemu-devel] [PATCH v4 02/12] block/nbd: Reject port parameter without host Max Reitz
2016-09-30 18:44 ` Eric Blake
2016-10-13 11:34 ` Kevin Wolf
2016-09-28 20:55 ` [Qemu-devel] [PATCH v4 03/12] block/nbd: Default port in nbd_refresh_filename() Max Reitz
2016-09-30 19:28 ` Eric Blake
2016-10-13 11:35 ` Kevin Wolf
2016-09-28 20:55 ` [Qemu-devel] [PATCH v4 04/12] block/nbd: Use qdict_put() Max Reitz
2016-10-03 15:31 ` Eric Blake
2016-10-13 11:35 ` Kevin Wolf
2016-09-28 20:55 ` [Qemu-devel] [PATCH v4 05/12] block/nbd: Add nbd_has_filename_options_conflict() Max Reitz
2016-10-03 18:46 ` Eric Blake
2016-10-04 17:29 ` Max Reitz
2016-10-13 11:35 ` Kevin Wolf
2016-09-28 20:55 ` [Qemu-devel] [PATCH v4 06/12] block/nbd: Accept SocketAddress Max Reitz
2016-10-13 11:42 ` Kevin Wolf
2016-10-14 9:34 ` Ashijeet Acharya
2016-10-15 17:12 ` Max Reitz
2016-09-28 20:55 ` [Qemu-devel] [PATCH v4 07/12] block/nbd: Use SocketAddress options Max Reitz
2016-10-13 13:01 ` Kevin Wolf
2016-09-28 20:55 ` [Qemu-devel] [PATCH v4 08/12] qapi: Allow blockdev-add for NBD Max Reitz
2016-10-13 13:01 ` Kevin Wolf
2016-09-28 20:55 ` [Qemu-devel] [PATCH v4 09/12] iotests.py: Add qemu_nbd function Max Reitz
2016-10-13 13:11 ` Kevin Wolf
2016-10-15 17:17 ` Max Reitz
2016-10-17 8:33 ` Kevin Wolf
2016-09-28 20:56 ` [Qemu-devel] [PATCH v4 10/12] iotests.py: Allow concurrent qemu instances Max Reitz
2016-10-13 13:12 ` Kevin Wolf
2016-09-28 20:56 ` [Qemu-devel] [PATCH v4 11/12] socket_scm_helper: Accept fd directly Max Reitz
2016-10-13 13:12 ` Kevin Wolf
2016-09-28 20:56 ` Max Reitz [this message]
2016-10-13 13:26 ` [Qemu-devel] [PATCH v4 12/12] iotests: Add test for NBD's blockdev-add interface Kevin Wolf
2016-10-15 17:19 ` Max Reitz
2016-10-14 4:09 ` [Qemu-devel] [PATCH v4 00/12] qapi: Allow blockdev-add for NBD no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928205602.17275-13-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.