From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49733)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1bpR35-0000mw-W4
	for qemu-devel@nongnu.org; Wed, 28 Sep 2016 22:26:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgibson@ozlabs.org>) id 1bpR34-0002Bo-Mh
	for qemu-devel@nongnu.org; Wed, 28 Sep 2016 22:26:11 -0400
Date: Thu, 29 Sep 2016 12:23:17 +1000
From: David Gibson <david@gibson.dropbear.id.au>
Message-ID: <20160929022317.GH8390@umbus.fritz.box>
References: <1475041518-9757-1-git-send-email-raji@linux.vnet.ibm.com>
	<1475041518-9757-7-git-send-email-raji@linux.vnet.ibm.com>
	<88e56a0e-f0ad-4077-8c91-39204d725307@twiddle.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="82evfD9Ogz2JrdWZ"
Content-Disposition: inline
In-Reply-To: <88e56a0e-f0ad-4077-8c91-39204d725307@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 6/6] target-ppc: add vclzlsbb/vctzlsbb
 instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, benh@kernel.crashing.org


--82evfD9Ogz2JrdWZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 28, 2016 at 10:08:06AM -0700, Richard Henderson wrote:
> On 09/27/2016 10:45 PM, Rajalakshmi Srinivasaraghavan wrote:
> > +    return count;
> > +}
> > +target_ulong helper_vctzlsbb(ppc_avr_t *r)
> > +{
>=20
> ...
>=20
> > +    return count;
> > +}
> >  void helper_vmhaddshs(CPUPPCState *env, ppc_avr_t *r, ppc_avr_t *a,
> >                        ppc_avr_t *b, ppc_avr_t *c)
>=20
> Watch your spacing between functions.  Otherwise,
>=20
> Reviewed-by: Richard Henderson <rth@twiddle.net>

I've added a couple of extra line breaks and applied to ppc-for-2.8.

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--82evfD9Ogz2JrdWZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJX7HsVAAoJEGw4ysog2bOSRVsQANUimHmPUuTnMAp4+vfMDb8w
bc7J8Me4JE78EEaSxVUhM+mYQ0YK+62iEoGYq6irmcaXOE7odIFgqplQBqB1lShL
1BAee7Re2TMIT3eZy6KxqZQgVuru2CTYCluzWPZPliZYOlbsNTZztdkxGWfO9emY
AzEw5cyc6Tj58X1c/ckYYgVguDMKXjMvgcCAr3qHp4uLNlHpD6yYtQLaTmmLJgrN
580dfoM2dmCDnIOk0yi6qHgU8nTWMuhKKTRenjlVgqsMNzYCRhvDpt2yRM5NCP1W
7dWBIl8dLmeH5+HS7GdYkkqRUore7LzhiN7SkyCZxbNujiNQiBVfU6SomboEZ7k3
9tzispNW7VwIK8fpgwidplGrYdIpT09gJj/vGcQTcV2EjrgI9rB2TF5yvVWPnCFb
hIGKVu44FGmtaBUZdJOI2118oi2pn5G5kntjnTkwX4TqfI2ChwOrmL8JUdEuyzPf
fjA5q9XHY43q149M0ydKjSvKBIBsShUHkA47rybLx4q3qTJr0joekDyQWN3gp/Ja
VdXUCzUe3ycbm1BYq8+VU1IA8WZ0Lz2/H0DvoN/5S5C861MHX0Y55szU2HGzzsB/
h9+wykJNtf8XQyjJnvt/RXHqenvZwYqBsVb1Xv0kzf1aRs93KlRrvGYAY+eSoD5e
M3eObS4vYvtwg0+kzlV7
=YugV
-----END PGP SIGNATURE-----

--82evfD9Ogz2JrdWZ--