Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/6] tests: enable ohci/uhci/xhci tests on PPC64

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2892 bytes --]

On Wed, Sep 28, 2016 at 08:51:27PM +0200, Laurent Vivier wrote:
> This series enables USB tests on PPC64, and for
> that implements libqos SPAPR PCI support.

These look good, except I still think the endianness is a bit
confused.  A more detailed analysis in response to patch 1.

Also, I'm afraid this is going to need another rebase, due to things
I've merged in ppc-for-2.8 today.

> 
> v3:
> - rebase
> - minor fixes (commas, comments)
> - add Greg's R-b
> 
> v2:
> - rebase
> - revert order in qtest_common_shutdown() to release
>   PCI and then memory allocator
> - remove useless byte-swapping in qpci-spapr.c
> - compute machine endianness on qtest_init()
> - introduce target_cpu_to_leXX()/target_cpu_to_beXX()
>             target_leXX_to_cpu()/target_beXX_to_cpu()
> 
> Laurent Vivier (6):
>   libqos: add PPC64 PCI support
>   libqos: add PCI management in qtest_vboot()/qtest_shutdown()
>   libqos: use generic qtest_shutdown()
>   qtest: evaluate endianness of the target in qtest_init()
>   qtest: define target cpu endianness conversion functions
>   tests: enable ohci/uhci/xhci tests on PPC64
> 
>  tests/Makefile.include      |   9 +-
>  tests/e1000e-test.c         |   2 +-
>  tests/i440fx-test.c         |   2 +-
>  tests/ide-test.c            |   2 +-
>  tests/ivshmem-test.c        |   2 +-
>  tests/libqos/ahci.c         |   2 +-
>  tests/libqos/libqos-pc.c    |   8 +-
>  tests/libqos/libqos-spapr.c |   8 +-
>  tests/libqos/libqos.c       |  32 ++++-
>  tests/libqos/libqos.h       |  11 +-
>  tests/libqos/pci-pc.c       |  24 +---
>  tests/libqos/pci-pc.h       |   3 +-
>  tests/libqos/pci-spapr.c    | 280 ++++++++++++++++++++++++++++++++++++++++++++
>  tests/libqos/pci-spapr.h    |  17 +++
>  tests/libqos/pci.c          |  22 +++-
>  tests/libqos/rtas.c         |  45 +++++++
>  tests/libqos/rtas.h         |   4 +
>  tests/libqos/usb.c          |   2 +-
>  tests/libqos/virtio-pci.c   |   2 +-
>  tests/libqtest.c            |  96 ++++++++-------
>  tests/libqtest.h            |  71 ++++++++++-
>  tests/q35-test.c            |   2 +-
>  tests/rtas-test.c           |   2 +-
>  tests/rtl8139-test.c        |   2 +-
>  tests/tco-test.c            |   2 +-
>  tests/usb-hcd-ehci-test.c   |   2 +-
>  tests/usb-hcd-uhci-test.c   |  24 ++--
>  tests/vhost-user-test.c     |   4 +-
>  tests/virtio-9p-test.c      |   2 +-
>  tests/virtio-blk-test.c     |   4 +-
>  tests/virtio-net-test.c     |   2 +-
>  tests/virtio-scsi-test.c    |   2 +-
>  32 files changed, 580 insertions(+), 112 deletions(-)
>  create mode 100644 tests/libqos/pci-spapr.c
>  create mode 100644 tests/libqos/pci-spapr.h
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]