* [PATCH] generic/349,350,351: remove from quick group
@ 2016-09-26 12:46 Eryu Guan
2016-09-29 7:52 ` Zorro Lang
0 siblings, 1 reply; 4+ messages in thread
From: Eryu Guan @ 2016-09-26 12:46 UTC (permalink / raw)
To: fstests; +Cc: Eryu Guan
These tests are meant to test block devices, so they're not in auto
group. And quick group is a subset of auto group, so remove quick as
well.
Signed-off-by: Eryu Guan <eguan@redhat.com>
---
tests/generic/group | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/generic/group b/tests/generic/group
index 879b1ef..dc8e70d 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -352,9 +352,9 @@
346 auto quick rw
347 auto quick rw thin
348 auto quick metadata
-349 blockdev quick rw zero
-350 blockdev quick rw punch
-351 blockdev quick rw punch collapse insert zero
+349 blockdev rw zero
+350 blockdev rw punch
+351 blockdev rw punch collapse insert zero
352 auto clone
353 auto quick clone
354 auto
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] generic/349,350,351: remove from quick group
2016-09-26 12:46 [PATCH] generic/349,350,351: remove from quick group Eryu Guan
@ 2016-09-29 7:52 ` Zorro Lang
2016-09-29 8:09 ` Eryu Guan
0 siblings, 1 reply; 4+ messages in thread
From: Zorro Lang @ 2016-09-29 7:52 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
On Mon, Sep 26, 2016 at 08:46:32PM +0800, Eryu Guan wrote:
> These tests are meant to test block devices, so they're not in auto
> group. And quick group is a subset of auto group, so remove quick as
> well.
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> tests/generic/group | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/generic/group b/tests/generic/group
> index 879b1ef..dc8e70d 100644
> --- a/tests/generic/group
> +++ b/tests/generic/group
> @@ -352,9 +352,9 @@
> 346 auto quick rw
> 347 auto quick rw thin
> 348 auto quick metadata
> -349 blockdev quick rw zero
> -350 blockdev quick rw punch
> -351 blockdev quick rw punch collapse insert zero
> +349 blockdev rw zero
> +350 blockdev rw punch
> +351 blockdev rw punch collapse insert zero
Can we use some methods to check if fallocate supports the features
for block devices at first? Then decide to keep running or _notrun() these
cases?
Because these cases are really 'quick', if they can be run automatically,
maybe we can add them into auto group?
Thanks,
Zorro
> 352 auto clone
> 353 auto quick clone
> 354 auto
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] generic/349,350,351: remove from quick group
2016-09-29 7:52 ` Zorro Lang
@ 2016-09-29 8:09 ` Eryu Guan
2016-09-29 8:14 ` Zorro Lang
0 siblings, 1 reply; 4+ messages in thread
From: Eryu Guan @ 2016-09-29 8:09 UTC (permalink / raw)
To: Zorro Lang; +Cc: fstests
On Thu, Sep 29, 2016 at 03:52:40PM +0800, Zorro Lang wrote:
> On Mon, Sep 26, 2016 at 08:46:32PM +0800, Eryu Guan wrote:
> > These tests are meant to test block devices, so they're not in auto
> > group. And quick group is a subset of auto group, so remove quick as
> > well.
> >
> > Signed-off-by: Eryu Guan <eguan@redhat.com>
> > ---
> > tests/generic/group | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/generic/group b/tests/generic/group
> > index 879b1ef..dc8e70d 100644
> > --- a/tests/generic/group
> > +++ b/tests/generic/group
> > @@ -352,9 +352,9 @@
> > 346 auto quick rw
> > 347 auto quick rw thin
> > 348 auto quick metadata
> > -349 blockdev quick rw zero
> > -350 blockdev quick rw punch
> > -351 blockdev quick rw punch collapse insert zero
> > +349 blockdev rw zero
> > +350 blockdev rw punch
> > +351 blockdev rw punch collapse insert zero
>
> Can we use some methods to check if fallocate supports the features
> for block devices at first? Then decide to keep running or _notrun() these
> cases?
>
> Because these cases are really 'quick', if they can be run automatically,
> maybe we can add them into auto group?
We didn't add them to 'auto' group on purpose.
http://oss.sgi.com/archives/xfs/2016-03/msg00288.html
I think removing 'quick' group is sufficient at this stage.
Thanks,
Eryu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] generic/349,350,351: remove from quick group
2016-09-29 8:09 ` Eryu Guan
@ 2016-09-29 8:14 ` Zorro Lang
0 siblings, 0 replies; 4+ messages in thread
From: Zorro Lang @ 2016-09-29 8:14 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
On Thu, Sep 29, 2016 at 04:09:30PM +0800, Eryu Guan wrote:
> On Thu, Sep 29, 2016 at 03:52:40PM +0800, Zorro Lang wrote:
> > On Mon, Sep 26, 2016 at 08:46:32PM +0800, Eryu Guan wrote:
> > > These tests are meant to test block devices, so they're not in auto
> > > group. And quick group is a subset of auto group, so remove quick as
> > > well.
> > >
> > > Signed-off-by: Eryu Guan <eguan@redhat.com>
> > > ---
> > > tests/generic/group | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/tests/generic/group b/tests/generic/group
> > > index 879b1ef..dc8e70d 100644
> > > --- a/tests/generic/group
> > > +++ b/tests/generic/group
> > > @@ -352,9 +352,9 @@
> > > 346 auto quick rw
> > > 347 auto quick rw thin
> > > 348 auto quick metadata
> > > -349 blockdev quick rw zero
> > > -350 blockdev quick rw punch
> > > -351 blockdev quick rw punch collapse insert zero
> > > +349 blockdev rw zero
> > > +350 blockdev rw punch
> > > +351 blockdev rw punch collapse insert zero
> >
> > Can we use some methods to check if fallocate supports the features
> > for block devices at first? Then decide to keep running or _notrun() these
> > cases?
> >
> > Because these cases are really 'quick', if they can be run automatically,
> > maybe we can add them into auto group?
>
> We didn't add them to 'auto' group on purpose.
>
> http://oss.sgi.com/archives/xfs/2016-03/msg00288.html
>
> I think removing 'quick' group is sufficient at this stage.
OK, if so, this patch looks good to me:)
Reviewed-by: Zorro Lang <zlang@redhat.com>
>
> Thanks,
> Eryu
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-29 8:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-26 12:46 [PATCH] generic/349,350,351: remove from quick group Eryu Guan
2016-09-29 7:52 ` Zorro Lang
2016-09-29 8:09 ` Eryu Guan
2016-09-29 8:14 ` Zorro Lang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.