All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, kwolf@redhat.com,
	Stefan Hajnoczi <stefanha@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] RFC: handling image options with drive-mirror/drive-backup
Date: Thu, 29 Sep 2016 17:09:20 +0800	[thread overview]
Message-ID: <20160929090920.GB1118@lemon> (raw)
In-Reply-To: <20160929085109.GG5312@redhat.com>

On Thu, 09/29 09:51, Daniel P. Berrange wrote:
> On Thu, Sep 29, 2016 at 04:43:25PM +0800, Fam Zheng wrote:
> > On Thu, 09/29 09:34, Daniel P. Berrange wrote:
> > > So my suggestion is that we deprecate "drive-mirror" and define a fixed
> > > command "drive-mirror-blockdev" (or "blockdev-mirror" ?) that accepts
> > > the proper BlockdevOptions QAPI type for the target as above.
> > 
> > Are you aware that there is already a blockdev-mirror command? Supposedly it
> > can do what you need, together with blockdev-add once the latter is deemed
> > ready.
> 
> Clearly I'm not aware of that :-)  It seems libvirt does not yet use
> blockdev-mirror either, which is where I got the original bug report
> about drive-mirror from.

Libvirt doesn't support blockdev-add yet, because the command is still being
actively worked on at QEMU side, and is therefore thought to be not "stable"
yet. Though, I think blockdev-add + blockdev-{mirror,backup} are already useful
for common tasks (like your use case with LUKS).

> 
> I'll submit a patch to mark drive-mirror as deprecated and point the
> otherwise ignorant reader towards blockdev-mirror instead....

For above reasons, not sure whether we want to advertise it already.
Anyway deprecating drive-mirror is a bit too early.

Fam

  reply	other threads:[~2016-09-29  9:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29  8:34 [Qemu-devel] RFC: handling image options with drive-mirror/drive-backup Daniel P. Berrange
2016-09-29  8:43 ` Fam Zheng
2016-09-29  8:51   ` Daniel P. Berrange
2016-09-29  9:09     ` Fam Zheng [this message]
2016-09-29  9:15       ` Daniel P. Berrange
2016-09-29  9:25         ` Fam Zheng
2016-09-29  9:17       ` Kevin Wolf
2016-09-29  9:43         ` Daniel P. Berrange
2016-09-29 10:29           ` Kashyap Chamarthy
2016-09-29 10:37           ` Kevin Wolf
2016-09-29  9:47     ` Kashyap Chamarthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160929090920.GB1118@lemon \
    --to=famz@redhat.com \
    --cc=berrange@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.