From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpXTe-0005Na-SC for qemu-devel@nongnu.org; Thu, 29 Sep 2016 05:18:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpXTc-0002lg-PK for qemu-devel@nongnu.org; Thu, 29 Sep 2016 05:18:01 -0400 Date: Thu, 29 Sep 2016 11:17:52 +0200 From: Kevin Wolf Message-ID: <20160929091752.GB5742@noname.redhat.com> References: <20160929083435.GE5312@redhat.com> <20160929084325.GA1118@lemon> <20160929085109.GG5312@redhat.com> <20160929090920.GB1118@lemon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160929090920.GB1118@lemon> Subject: Re: [Qemu-devel] RFC: handling image options with drive-mirror/drive-backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: "Daniel P. Berrange" , qemu-devel@nongnu.org, Stefan Hajnoczi , qemu-block@nongnu.org Am 29.09.2016 um 11:09 hat Fam Zheng geschrieben: > On Thu, 09/29 09:51, Daniel P. Berrange wrote: > > On Thu, Sep 29, 2016 at 04:43:25PM +0800, Fam Zheng wrote: > > > On Thu, 09/29 09:34, Daniel P. Berrange wrote: > > > > So my suggestion is that we deprecate "drive-mirror" and define a fixed > > > > command "drive-mirror-blockdev" (or "blockdev-mirror" ?) that accepts > > > > the proper BlockdevOptions QAPI type for the target as above. > > > > > > Are you aware that there is already a blockdev-mirror command? Supposedly it > > > can do what you need, together with blockdev-add once the latter is deemed > > > ready. > > > > Clearly I'm not aware of that :-) It seems libvirt does not yet use > > blockdev-mirror either, which is where I got the original bug report > > about drive-mirror from. > > Libvirt doesn't support blockdev-add yet, because the command is still being > actively worked on at QEMU side, and is therefore thought to be not "stable" > yet. Though, I think blockdev-add + blockdev-{mirror,backup} are already useful > for common tasks (like your use case with LUKS). Just to clarify what "not stable" means: Literally none of the blockdev-add commands that used to work when it was originally merged are still working. And we're considering another similar change (removing the "options" indirection) that will change the command for all users. So while I would encourage libvirt to write prototyp code for supporting blockdev-add now, I would advise against enabling it in a release yet. > > I'll submit a patch to mark drive-mirror as deprecated and point the > > otherwise ignorant reader towards blockdev-mirror instead.... > > For above reasons, not sure whether we want to advertise it already. > Anyway deprecating drive-mirror is a bit too early. That was my first thought, too. However, blockdev-{mirror,backup} can also work with drives added with -drive or drive_add, so it might be useful enough even without blockdev-add. Kevin