From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpXvz-00022D-VR for qemu-devel@nongnu.org; Thu, 29 Sep 2016 05:47:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpXvy-00027F-Sq for qemu-devel@nongnu.org; Thu, 29 Sep 2016 05:47:19 -0400 Date: Thu, 29 Sep 2016 11:47:10 +0200 From: Kashyap Chamarthy Message-ID: <20160929094710.nj6r7daypajrrfbp@eukaryote> References: <20160929083435.GE5312@redhat.com> <20160929084325.GA1118@lemon> <20160929085109.GG5312@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160929085109.GG5312@redhat.com> Subject: Re: [Qemu-devel] RFC: handling image options with drive-mirror/drive-backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Fam Zheng , kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi On Thu, Sep 29, 2016 at 09:51:09AM +0100, Daniel P. Berrange wrote: > On Thu, Sep 29, 2016 at 04:43:25PM +0800, Fam Zheng wrote: > > On Thu, 09/29 09:34, Daniel P. Berrange wrote: [...] > > > So my suggestion is that we deprecate "drive-mirror" and define a fixed > > > command "drive-mirror-blockdev" (or "blockdev-mirror" ?) that accepts > > > the proper BlockdevOptions QAPI type for the target as above. > > > > Are you aware that there is already a blockdev-mirror command? Supposedly it > > can do what you need, together with blockdev-add once the latter is deemed > > ready. > > Clearly I'm not aware of that :-) It seems libvirt does not yet use > blockdev-mirror either, which is where I got the original bug report > about drive-mirror from. > > I'll submit a patch to mark drive-mirror as deprecated and point the > otherwise ignorant reader towards blockdev-mirror instead.... You might also want to see this short thread I started last month to clarify the semantics of `drive-mirror` & `blockdev-mirror` https://lists.nongnu.org/archive/html/qemu-block/2016-08/msg00472.html -- 'drive-mirror' vs. 'blockdev-mirror' semantics Kevin's response to the above: https://lists.nongnu.org/archive/html/qemu-block/2016-08/msg00493.html Some addendum to Kevin's response above: https://lists.nongnu.org/archive/html/qemu-block/2016-08/msg00503.html And FWIW, here's some tests of `blockdev-add` + `blockdev-backup` (`blockdev-mirror` is similar, just a different point-in-time -- point-in-time for 'drive-mirror' is when you break the synchronization; and the point-in-time for 'drive-backup' is when you _start_ the operation): https://kashyapc.fedorapeople.org/virt/qemu/blockdev-add-and-blockdev-backup-success-tests.txt -- /kashyap