All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Xu <peterx@redhat.com>, Igor Mammedov <imammedo@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v2 1/7] apic: add global apic_get_class()
Date: Thu, 29 Sep 2016 13:23:23 +0200	[thread overview]
Message-ID: <20160929112329.2408-2-rkrcmar@redhat.com> (raw)
In-Reply-To: <20160929112329.2408-1-rkrcmar@redhat.com>

Every configuration has only up to one APIC class and we'll be extending
the class with a function that can be called without an instanced
object, so a direct access to the class is convenient.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
v2: assert() instead of error_report() and exit() [Peter]
---
 hw/intc/apic_common.c           | 11 +++++++++++
 include/hw/i386/apic_internal.h |  3 +++
 2 files changed, 14 insertions(+)

diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
index 14ac43c18666..a766f0efc805 100644
--- a/hw/intc/apic_common.c
+++ b/hw/intc/apic_common.c
@@ -18,6 +18,7 @@
  * License along with this library; if not, see <http://www.gnu.org/licenses/>
  */
 #include "qemu/osdep.h"
+#include "qemu/error-report.h"
 #include "qapi/error.h"
 #include "qemu-common.h"
 #include "cpu.h"
@@ -296,6 +297,13 @@ static int apic_load_old(QEMUFile *f, void *opaque, int version_id)
 
 static const VMStateDescription vmstate_apic_common;
 
+APICCommonClass *apic_class;
+
+APICCommonClass *apic_get_class(void)
+{
+    return apic_class;
+}
+
 static void apic_common_realize(DeviceState *dev, Error **errp)
 {
     APICCommonState *s = APIC_COMMON(dev);
@@ -306,6 +314,9 @@ static void apic_common_realize(DeviceState *dev, Error **errp)
     info = APIC_COMMON_GET_CLASS(s);
     info->realize(dev, errp);
 
+    assert(apic_class == info || !apic_class);
+    apic_class = info;
+
     /* Note: We need at least 1M to map the VAPIC option ROM */
     if (!vapic && s->vapic_control & VAPIC_ENABLE_MASK &&
         ram_size >= 1024 * 1024) {
diff --git a/include/hw/i386/apic_internal.h b/include/hw/i386/apic_internal.h
index 06c4e9f6f95b..9ba8a5c87f90 100644
--- a/include/hw/i386/apic_internal.h
+++ b/include/hw/i386/apic_internal.h
@@ -222,4 +222,7 @@ static inline int apic_get_bit(uint32_t *tab, int index)
     return !!(tab[i] & mask);
 }
 
+
+APICCommonClass *apic_get_class(void);
+
 #endif /* QEMU_APIC_INTERNAL_H */
-- 
2.10.0

  reply	other threads:[~2016-09-29 11:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29 11:23 [Qemu-devel] [PATCH v2 0/7] intel_iommu: fix EIM Radim Krčmář
2016-09-29 11:23 ` Radim Krčmář [this message]
2016-09-29 14:53   ` [Qemu-devel] [PATCH v2 1/7] apic: add global apic_get_class() Eduardo Habkost
2016-09-29 15:58     ` Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 2/7] apic: add send_msi() to APICCommonClass Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 3/7] intel_iommu: pass whole remapped addresses to apic Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 4/7] intel-iommu: exit on invalid configuraton earlier Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 5/7] intel-iommu: add OnOffAuto intr_eim as "eim" property Radim Krčmář
2016-09-30  5:13   ` Peter Xu
2016-09-30 13:50     ` Radim Krčmář
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 6/7] intel_iommu: reject broken EIM Radim Krčmář
2016-09-29 13:18   ` Paolo Bonzini
2016-09-29 16:06     ` Igor Mammedov
2016-09-29 16:56       ` Radim Krčmář
2016-09-29 16:56         ` Paolo Bonzini
2016-09-29 15:53   ` Igor Mammedov
2016-09-29 11:23 ` [Qemu-devel] [PATCH v2 7/7] intel-iommu: keep buggy EIM enabled in 2.7 machine type Radim Krčmář
2016-09-29 13:19   ` Paolo Bonzini
2016-09-29 15:01   ` Eduardo Habkost
2016-09-29 16:49     ` Radim Krčmář
2016-09-30  5:40   ` Peter Xu
2016-09-30 13:55     ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160929112329.2408-2-rkrcmar@redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.