From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934067AbcI2QyF (ORCPT ); Thu, 29 Sep 2016 12:54:05 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:36617 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755316AbcI2Qx4 (ORCPT ); Thu, 29 Sep 2016 12:53:56 -0400 Date: Thu, 29 Sep 2016 17:56:02 +0100 From: Lee Jones To: "Kraemer, Matthias (Ferchau; ADITG/SW1)" Cc: Mika Westerberg , "linux-mtd@lists.infradead.org" , Brian Norris , David Woodhouse , Peter Tyser , "key.seong.lim@intel.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC Message-ID: <20160929165602.GA2844@dell> References: <1471245044-12767-1-git-send-email-mika.westerberg@linux.intel.com> <1471245044-12767-4-git-send-email-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Sep 2016, Kraemer, Matthias (Ferchau; ADITG/SW1) wrote: > Hello Mika, > > In line 1239 you specify "struct pci_bus *bus = dev->bus;" > }, @@ -1122,6 +1131,36 @@ static int lpc_ich_init_spi(struct pci_dev *dev) > } > break; > > + case INTEL_SPI_BXT: { > + unsigned int p2sb = PCI_DEVFN(13, 0); > + unsigned int spi = PCI_DEVFN(13, 2); > + struct pci_bus *bus = dev->bus; > > but in line 1262 you are using dev->bus again. > + > + pci_bus_write_config_byte(dev->bus, p2sb, 0xe1, 0x1); > > Sure this is not a runtime issue, but it would be nice to keep the coding-style consistent. > We could just use dev->bus for BXT SOCs, like the remaining parts of this driver do. > > Kind regards > Matthias Kraemer Please reply in-line. It is considered bad etiquette to top-post like this. > -----Original Message----- > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Mika Westerberg > Sent: Montag, 15. August 2016 09:11 > To: linux-mtd@lists.infradead.org > Cc: Brian Norris; David Woodhouse; Lee Jones; Peter Tyser; key.seong.lim@intel.com; Mika Westerberg; linux-kernel@vger.kernel.org > Subject: [PATCH v3 3/3] mfd: lpc_ich: Add support for Intel Apollo Lake SoC Please fix your mailer. This is crud and should not be quoted. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog