From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp1040.oracle.com ([156.151.31.81]:34177 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934123AbcI2RpY (ORCPT ); Thu, 29 Sep 2016 13:45:24 -0400 Date: Thu, 29 Sep 2016 10:44:44 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 10/63] xfs: create refcount update intent log items Message-ID: <20160929174443.GY14092@birch.djwong.org> References: <147503120985.30303.14151302091684456858.stgit@birch.djwong.org> <147503127360.30303.13509008550712587655.stgit@birch.djwong.org> <20160929165257.GD4546@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160929165257.GD4546@infradead.org> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Christoph Hellwig Cc: david@fromorbit.com, linux-xfs@vger.kernel.org On Thu, Sep 29, 2016 at 09:52:57AM -0700, Christoph Hellwig wrote: > > +int > > +xfs_cui_copy_format( > > + struct xfs_log_iovec *buf, > > + struct xfs_cui_log_format *dst_cui_fmt) > > +{ > > + struct xfs_cui_log_format *src_cui_fmt; > > + uint len; > > + > > + src_cui_fmt = buf->i_addr; > > + len = xfs_cui_log_format_sizeof(src_cui_fmt->cui_nextents); > > + > > + if (buf->i_len == len) { > > + memcpy(dst_cui_fmt, src_cui_fmt, len); > > + return 0; > > + } > > + return -EFSCORRUPTED; > > +} > > I'd still much prefer this to be inlined in the only caller. I decided I might as well move this and xfs_bui_copy_format. --D > But except for that this looks fine: > > Reviewed-by: Christoph Hellwig