From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46444)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1bpuwS-0000e1-0l
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 06:21:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1bpuwM-00066v-12
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 06:21:18 -0400
Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1bpuwL-00066r-Qd
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 06:21:13 -0400
Received: by mail-wm0-x243.google.com with SMTP id p138so2765908wmb.0
	for <qemu-devel@nongnu.org>; Fri, 30 Sep 2016 03:21:13 -0700 (PDT)
Date: Fri, 30 Sep 2016 12:21:11 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20160930102111.GC9606@toto>
References: <20160921082958.18035.57524.malonedeb@wampee.canonical.com>
	<20160922095309.27899.16033.malone@chaenomeles.canonical.com>
	<CAFEAcA-KhQF+SmW5a0L49Td=JU6QQY1XaF9sNXPKbKyj8LX8Mg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-KhQF+SmW5a0L49Td=JU6QQY1XaF9sNXPKbKyj8LX8Mg@mail.gmail.com>
Subject: Re: [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028:
 possible coding error ?
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, Bug 1625987 <1625987@bugs.launchpad.net>

On Thu, Sep 29, 2016 at 06:40:53PM -0700, Peter Maydell wrote:
> On 22 September 2016 at 02:53, Peter Maydell <peter.maydell@linaro.org> wrote:
> > This is clearly a bug, but your suggested change won't deal with the
> > problem, which is that we're trying to set a bool so the ? 32 : 64
> > construct is just wrong.
> 
> > Bug description:
> >   target-arm/translate-a64.c:2028:37: warning: ?: using integer
> >   constants in boolean context [-Wint-in-bool-context]
> >
> >   Source code is
> >
> >           bool iss_sf = opc == 0 ? 32 : 64;
> 
> Edgar, did you want to look at a fix for this? It was introduced
> in your commit aaa1f954d4 adding syndrome info for loads and stores.

Hi Peter,

Yes, I've just posted a fix to the list.
It should have been:

bool iss_sf = opc == 0 ? false : true;

Cheers,
Edgar