From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750949AbcJAKRZ (ORCPT ); Sat, 1 Oct 2016 06:17:25 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36300 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750751AbcJAKRV (ORCPT ); Sat, 1 Oct 2016 06:17:21 -0400 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Steven Rostedt Subject: [PATCH] tools lib traceevent: Fix kbuffer_read_at_offset() Date: Sat, 1 Oct 2016 19:17:00 +0900 Message-Id: <20161001101700.29146-1-namhyung@kernel.org> X-Mailer: git-send-email 2.10.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When it's called with an offset less than or equal to the first event, it'll return a garbage value since the data is not initialized. Cc: Steven Rostedt Signed-off-by: Namhyung Kim --- tools/lib/traceevent/kbuffer-parse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/lib/traceevent/kbuffer-parse.c b/tools/lib/traceevent/kbuffer-parse.c index 3bcada3ae05a..65984f1c2974 100644 --- a/tools/lib/traceevent/kbuffer-parse.c +++ b/tools/lib/traceevent/kbuffer-parse.c @@ -622,6 +622,7 @@ void *kbuffer_read_at_offset(struct kbuffer *kbuf, int offset, /* Reset the buffer */ kbuffer_load_subbuffer(kbuf, kbuf->subbuffer); + data = kbuffer_read_event(kbuf, ts); while (kbuf->curr < offset) { data = kbuffer_next_event(kbuf, ts); -- 2.10.0