All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Tourrilhes <jt@labs.hpe.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/1 v2] eal: Fix misleading error messages, errno can't be trusted.
Date: Mon, 3 Oct 2016 09:07:42 -0700	[thread overview]
Message-ID: <20161003160742.GC23662@labs.hpe.com> (raw)
In-Reply-To: <4a84de40-04b9-da6d-aeb9-ce661a9ebad5@intel.com>

On Mon, Oct 03, 2016 at 02:25:40PM +0100, Sergio Gonzalez Monroy wrote:
> Hi Jean,
> 
> NIT but any reason you moved the check before closing the file descriptor?
> (not that it matters with current code as we panic anyway)
> 
> Thanks,
> Sergio

	More details, as I admit I was terse
	Running secondary is tricky due to the need to map the memory
region at the right place, which is whatever primary has chosen. If
the base address for primary happens to by already mapped in the
secondary, we will hit precisely this error message (well, in a few
case we might hit the other one). This is why there is already
a comment about ASLR.
	A colleague of mine hit that message and was misled by errno
claiming "permission denied", which sent him down the wrong
track. It's such a common error for secondary that I feel this error
message should be unambiguous and helpful.
	Regards,

	Jean

      parent reply	other threads:[~2016-10-03 16:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21 21:10 [PATCH 1/1 v2] eal: Fix misleading error messages, errno can't be trusted Jean Tourrilhes
2016-10-03 13:25 ` Sergio Gonzalez Monroy
2016-10-03 15:55   ` Jean Tourrilhes
2016-10-03 16:15     ` Mcnamara, John
2016-10-03 16:34       ` Jean Tourrilhes
2016-10-03 20:46     ` Thomas Monjalon
2016-10-04  8:03       ` Sergio Gonzalez Monroy
2016-10-04  9:31         ` Thomas Monjalon
2016-10-04 17:17           ` [PATCH v2 1/3] mem: fix hugepage mapping error messages Jean Tourrilhes
2016-10-04 19:07             ` Sergio Gonzalez Monroy
2016-10-05  9:51               ` Thomas Monjalon
2016-10-05 16:41                 ` Jean Tourrilhes
2016-10-03 16:07   ` Jean Tourrilhes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161003160742.GC23662@labs.hpe.com \
    --to=jt@labs.hpe.com \
    --cc=dev@dpdk.org \
    --cc=jean.tourrilhes@hpe.com \
    --cc=sergio.gonzalez.monroy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.