From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753225AbcJCVEA (ORCPT ); Mon, 3 Oct 2016 17:04:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34105 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbcJCVDw (ORCPT ); Mon, 3 Oct 2016 17:03:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 1B7106141A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Mon, 3 Oct 2016 14:03:50 -0700 From: Stephen Boyd To: kgunda@codeaurora.org Cc: Mark Brown , Greg Kroah-Hartman , Sudip Mukherjee , linux-kernel@vger.kernel.org, aghayal@qti.qualcomm.com, adharmap@codeaurora.org Subject: Re: [PATCH] spmi: regmap: enable userspace writes Message-ID: <20161003210350.GB8871@codeaurora.org> References: <1475148990-11272-1-git-send-email-kgunda@codeaurora.org> <20160929180016.6tk24tltbzplzlpp@sirena.org.uk> <128966d05cff74d2da786abfb0404071@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <128966d05cff74d2da786abfb0404071@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/30, kgunda@codeaurora.org wrote: > On 2016-09-29 23:30, Mark Brown wrote: > >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: > > > >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS > >>+#define REGMAP_ALLOW_WRITE_DEBUGFS > > > >This is completely inappropriate for upstream, if you need to do > >debugging on your platform you can enable this locally but enabling > >random writes from userspace to any regmap device is really not a good > >idea for system stablity or robustness. > > Sure. I will remove this change and send the next version only to update > the spmi device name. Why? The device name looks fine. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project