From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brMj6-0004xs-62 for qemu-devel@nongnu.org; Tue, 04 Oct 2016 06:13:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brMj0-0005e4-4c for qemu-devel@nongnu.org; Tue, 04 Oct 2016 06:13:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brMiz-0005df-Ud for qemu-devel@nongnu.org; Tue, 04 Oct 2016 06:13:26 -0400 Date: Tue, 4 Oct 2016 11:13:22 +0100 From: Stefan Hajnoczi Message-ID: <20161004101322.GH4587@stefanha-x1.localdomain> References: <1475051152-400276-1-git-send-email-arei.gonglei@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hAW+M2+FUO+onfmf" Content-Disposition: inline In-Reply-To: <1475051152-400276-1-git-send-email-arei.gonglei@huawei.com> Subject: Re: [Qemu-devel] [PATCH v4 00/13] virtio-crypto: introduce framework and device emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gonglei Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org, luonengjun@huawei.com, mst@redhat.com, pbonzini@redhat.com, berrange@redhat.com, weidong.huang@huawei.com, wu.wubin@huawei.com, mike.caraman@nxp.com, agraf@suse.de, xin.zeng@intel.com, claudio.fontana@huawei.com, nmorey@kalray.eu, vincent.jardin@6wind.com, jianjay.zhou@huawei.com, hanweidong@huawei.com, peter.huangpeng@huawei.com --hAW+M2+FUO+onfmf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 28, 2016 at 04:25:39PM +0800, Gonglei wrote: > The virtio crypto is a virtual crypto device as well as a kind > of virtual hardware accelerator for virtual machines. The > encryption and decryption requests are placed in the data > queue and handled by the real crypto accelerators finally. > The second queue is the control queue used to create or > destroy sessions for symmetric algorithms and control > some advanced features in the future. The virtio crypto > device provides the following crypto services: CIPHER, > MAC, HASH, AEAD etc. Please look at my reply to the virtio-crypto spec email thread. Changes to the request layout are necessary (dropping custom scatter-gather I/O, avoiding assumptions about iovec layout, ordering of device-readable/writable buffers). This will change the code quite a bit so I won't review further for now. Stefan --hAW+M2+FUO+onfmf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJX84DCAAoJEJykq7OBq3PISqMIAIREtnQEk1cOeJf+74zRccux a4KnrXPA6QfpfCypNvhKw9oIhSRPFbzz5f/nJRZxCITtK8EfZfaseuTMLhXklCNp WLDpQQs+Y4E4CQcBaA4pegaRv61ygsTtgzRyangdzuu6MBBy+DNdmV1Tf1YuiEqn b4q2T/i/fzDxTU/4/6DnASEuyvvTKCYWf/jx6j/EenX1KHui3C9hv5rb/bjb4OGn m32wfmLnEsbd1rf0rXG5fX5KIeTLRcq/jJRPabfablCuxZ9dNc0ScKvMek7p4FW9 v7afZnzSAqRGf72ttRdrWxY3MEjkKMcOTlFbVPXHuITQ8qYA1x3tZKgudGy4MVk= =hmIo -----END PGP SIGNATURE----- --hAW+M2+FUO+onfmf--