From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754604AbcJEIJ1 (ORCPT ); Wed, 5 Oct 2016 04:09:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58640 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753122AbcJEIJY (ORCPT ); Wed, 5 Oct 2016 04:09:24 -0400 Date: Wed, 5 Oct 2016 10:09:21 +0200 From: Jiri Olsa To: Michael Ellerman Cc: Peter Zijlstra , Michael Neuling , Paul Mackerras , Jiri Olsa , lkml , Ingo Molnar , Alexander Shishkin , Jan Stancek Subject: Re: [PATCH] perf powerpc: Don't call perf_event_disable from atomic context Message-ID: <20161005080921.GB6467@krava> References: <1474466134-21823-1-git-send-email-jolsa@kernel.org> <20160923163747.GE5012@twins.programming.kicks-ass.net> <20161003132932.GA28947@krava> <20161003134740.GC3117@twins.programming.kicks-ass.net> <87shsc4tzm.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87shsc4tzm.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.7.0 (2016-08-17) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 05 Oct 2016 08:09:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 04, 2016 at 03:29:33PM +1100, Michael Ellerman wrote: SNIP > Which is where we cope with the possibility that we couldn't emulate the > instruction that hit the breakpoint. Seems that is not an issue on x86, > or it's handled elsewhere? > > We should fix emulate_step() if it failed to emulate something it > should have, but there will always be the possibility that it fails. > > Instead of calling perf_event_disable() we could just add a flag to > arch_hw_breakpoint that says we hit an error on the event, and block > reinstalling it in arch_install_hw_breakpoint(). ok, might be easier.. I'll check on that thanks, jirka