From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754862AbcJEKpc (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Oct 2016 06:45:32 -0400
Received: from mail.kernel.org ([198.145.29.136]:44074 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754833AbcJEKpb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Oct 2016 06:45:31 -0400
Date: Wed, 5 Oct 2016 07:45:17 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Don Zickus <dzickus@redhat.com>, Joe Mario <jmario@redhat.com>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key
Message-ID: <20161005104517.GJ7143@kernel.org>
References: <1474558645-19956-1-git-send-email-jolsa@kernel.org>
 <1474558645-19956-21-git-send-email-jolsa@kernel.org>
 <20161004165012.GH7143@kernel.org>
 <20161004224612.GA10962@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161004224612.GA10962@krava>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Oct 05, 2016 at 12:46:12AM +0200, Jiri Olsa escreveu:
> On Tue, Oct 04, 2016 at 01:50:12PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Sep 22, 2016 at 05:36:48PM +0200, Jiri Olsa escreveu:
> > > Adding dcacheline dimension key support. It
> > > displays cacheline address as hex number.
> > > 
> > > Using c2c wrapper to standard 'dcacheline' object
> > > to defined own header and simple (just address)
> > > cacheline output.
> > 
> > So, at this point I move from:
> > 
> >   # perf c2c report
> >    Error: Invalid --fields key: `dcacheline'
> >   #
> > 
> > To:
> > 
> >   [root@jouet ~]# perf c2c report
> >   Error: Unknown --fields key: `offset'
> >   Segmentation fault (core dumped)
> >   [root@jouet ~]#
> 
> oops, attached patch should fix that, but I needed to change
> following patches:
> 
>   perf c2c report: Add cacheline hists processing
>   perf c2c report: Decode c2c_stats for hist entries
> 
> I updated perf/c2c_v4 branch with the fix and rebased
> to your current perf/core.. let me know if I need to
> repost
> 
> thanks,
> jirka

ok, I'm trying to fix it myself, starting with this:

+       ret = c2c_hists__init(hists, sort);
+       if (ret)
+               free(hists);
+
+       return &hists->hists;

That is on "perf c2c report: Add cacheline hists processing"
 
> 
> ---
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index 335c0fd30757..74c7822460e1 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -86,7 +86,7 @@ he__get_c2c_hists(struct hist_entry *he,
>  
>  	ret = c2c_hists__init(hists, sort);
>  	if (ret)
> -		free(hists);
> +		zfree(&hists);
>  
>  	return hists;
>  }