All of lore.kernel.org
 help / color / mirror / Atom feed
From: dcb <1630527@bugs.launchpad.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 1630527] [NEW] qemu/hw/i386/amd_iommu.c:188: possible bad shift ?
Date: Wed, 05 Oct 2016 10:50:35 -0000	[thread overview]
Message-ID: <20161005105036.22226.42277.malonedeb@soybean.canonical.com> (raw)

Public bug reported:

qemu/hw/i386/amd_iommu.c:188]: (error) Shifting 32-bit value by 64 bits
is undefined behaviour

Source code is

    uint64_t mask = ((1 << length) - 1) << bitpos;

Maybe better code

    uint64_t mask = ((1ULL << length) - 1) << bitpos;

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1630527

Title:
  qemu/hw/i386/amd_iommu.c:188: possible bad shift ?

Status in QEMU:
  New

Bug description:
  qemu/hw/i386/amd_iommu.c:188]: (error) Shifting 32-bit value by 64
  bits is undefined behaviour

  Source code is

      uint64_t mask = ((1 << length) - 1) << bitpos;

  Maybe better code

      uint64_t mask = ((1ULL << length) - 1) << bitpos;

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1630527/+subscriptions

             reply	other threads:[~2016-10-05 11:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-05 10:50 dcb [this message]
2016-10-12 14:54 ` [Qemu-devel] [Bug 1630527] Re: qemu/hw/i386/amd_iommu.c:188: possible bad shift ? T. Huth
2017-01-16 11:45 ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161005105036.22226.42277.malonedeb@soybean.canonical.com \
    --to=1630527@bugs.launchpad.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.