From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754037AbcJEMjE (ORCPT <rfc822;w@1wt.eu>);
        Wed, 5 Oct 2016 08:39:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31193 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753372AbcJEMjA (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 5 Oct 2016 08:39:00 -0400
Date: Wed, 5 Oct 2016 14:38:54 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Don Zickus <dzickus@redhat.com>, Joe Mario <jmario@redhat.com>,
        Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Namhyung Kim <namhyung@kernel.org>, David Ahern <dsahern@gmail.com>,
        Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 20/57] perf c2c report: Add dcacheline dimension key
Message-ID: <20161005123854.GA14500@krava>
References: <1474558645-19956-1-git-send-email-jolsa@kernel.org>
 <1474558645-19956-21-git-send-email-jolsa@kernel.org>
 <20161004165012.GH7143@kernel.org>
 <20161004224612.GA10962@krava>
 <20161005104517.GJ7143@kernel.org>
 <20161005105036.GK7143@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161005105036.GK7143@kernel.org>
User-Agent: Mutt/1.7.0 (2016-08-17)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 05 Oct 2016 12:38:59 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 05, 2016 at 07:50:36AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Oct 05, 2016 at 07:45:17AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Oct 05, 2016 at 12:46:12AM +0200, Jiri Olsa escreveu:
> > > On Tue, Oct 04, 2016 at 01:50:12PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Em Thu, Sep 22, 2016 at 05:36:48PM +0200, Jiri Olsa escreveu:
> > > > > Adding dcacheline dimension key support. It
> > > > > displays cacheline address as hex number.
> > > > > 
> > > > > Using c2c wrapper to standard 'dcacheline' object
> > > > > to defined own header and simple (just address)
> > > > > cacheline output.
> > > > 
> > > > So, at this point I move from:
> > > > 
> > > >   # perf c2c report
> > > >    Error: Invalid --fields key: `dcacheline'
> > > >   #
> > > > 
> > > > To:
> > > > 
> > > >   [root@jouet ~]# perf c2c report
> > > >   Error: Unknown --fields key: `offset'
> > > >   Segmentation fault (core dumped)
> > > >   [root@jouet ~]#
> > > 
> > > oops, attached patch should fix that, but I needed to change
> > > following patches:
> 
> Now we're at:
> 
> [root@jouet ~]# perf c2c report
>   Error: Unknown --fields key: `offset'
> 0x50cbc0 [0x8]: failed to process type: 68
> failed to process sample
> [root@jouet ~]#

well thats because we implicitly sort by offset but
there's no 'offset' ket support yet in your branch

basically the perf report does not display/do anything
till following patch:

  perf c2c report: Add stdio output support

I made sure now that the perf c2c report wont crash
till that patch..

jirka