From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45956)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1broAR-0005z9-QJ
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 11:31:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1broAM-0004NA-Qx
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 11:31:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1broAM-0004N2-Hj
	for qemu-devel@nongnu.org; Wed, 05 Oct 2016 11:31:30 -0400
Date: Wed, 5 Oct 2016 16:31:27 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20161005153127.GA30075@stefanha-x1.localdomain>
References: <1475588159-30598-1-git-send-email-berrange@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j"
Content-Disposition: inline
In-Reply-To: <1475588159-30598-1-git-send-email-berrange@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 00/20] Refactor trace to allow modular
 build
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, =?iso-8859-1?Q?Llu=EDs?= Vilanova <vilanova@ac.upc.edu>


--nFreZHaLTZJo0R7j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hmm...the SystemTap simpletrace script does not work anymore for me.  But I've
tested qemu.git/master and get the same results.

Did you test it successfully somehow?

$ cat x86_64-softmmu/qemu-system-x86_64.stp \
      x86_64-softmmu/qemu-system-x86_64-simpletrace.stp >test.stp
$ echo 'probe qemu.system.x86_64.simpletrace.* {}' >>test.stp

$ sudo stap test.stp -c 'x86_64-softmmu/qemu-system-x86_64 -enable-kvm' >/tmp/trace.dat

$ scripts/simpletrace.py trace-events-all /tmp/trace.dat
Traceback (most recent call last):
  File "scripts/simpletrace.py", line 217, in <module>
    run(Formatter())
  File "scripts/simpletrace.py", line 192, in run
    process(events, sys.argv[2], analyzer, read_header=read_header)
  File "scripts/simpletrace.py", line 167, in process
    for rec in read_trace_records(edict, log):
  File "scripts/simpletrace.py", line 103, in read_trace_records
    rec = read_record(edict, idtoname, fobj)
  File "scripts/simpletrace.py", line 71, in read_record
    return get_record(edict, idtoname, rechdr, fobj)
  File "scripts/simpletrace.py", line 43, in get_record
    name = idtoname[event_id]
KeyError: 1475680158726993795

$ scripts/simpletrace.py --no-header trace-events-all /tmp/trace.dat
Traceback (most recent call last):
  File "scripts/simpletrace.py", line 217, in <module>
    run(Formatter())
  File "scripts/simpletrace.py", line 192, in run
    process(events, sys.argv[2], analyzer, read_header=read_header)
  File "scripts/simpletrace.py", line 167, in process
    for rec in read_trace_records(edict, log):
  File "scripts/simpletrace.py", line 103, in read_trace_records
    rec = read_record(edict, idtoname, fobj)
  File "scripts/simpletrace.py", line 71, in read_record
    return get_record(edict, idtoname, rechdr, fobj)
  File "scripts/simpletrace.py", line 43, in get_record
    name = idtoname[event_id]
KeyError: 17487890541996943796L

$ xxd -l 256 /tmp/trace.dat
00000000: ffff ffff ffff ffff b429 a40a cb77 b1f2  .........)...w..
00000010: 0400 0000 0000 0000 3005 0000 0000 0000  ........0.......
00000020: 83b7 032f 49ab 7a14 5b00 0000 e674 0000  .../I.z.[....t..
00000030: 0600 0000 6465 7669 6365 0600 0000 6465  ....device....de
00000040: 7669 6365 0e00 0000 6877 2f63 6f72 652f  vice....hw/core/
00000050: 7164 6576 2e63 6504 0000 0000 0000 1100  qdev.ce.........
00000060: 0000 6465 7669 6365 5f63 6c61 7373 5f69  ..device_class_i
00000070: 6e69 7400 0000 0000 0000 0000 0000 0000  nit.............
00000080: 0000 0020 0000 006f 626a 6563 745f 636c  ... ...object_cl
00000090: 6173 735f 6479 6e61 6d69 635f 6361 7374  ass_dynamic_cast
000000a0: 5f61 7373 6572 7401 0000 0000 0000 0000  _assert.........
000000b0: 0000 0000 0000 00a7 ca03 2f49 ab7a 145b  ........../I.z.[
000000c0: 0000 00e6 7400 0006 0000 0064 6576 6963  ....t......devic
000000d0: 6506 0000 0064 6576 6963 650e 0000 0068  e....device....h
000000e0: 772f 636f 7265 2f71 6465 762e 6365 0400  w/core/qdev.ce..
000000f0: 0000 0000 0011 0000 0064 6576 6963 655f  .........device_

--nFreZHaLTZJo0R7j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEcBAEBAgAGBQJX9RzPAAoJEJykq7OBq3PIkLgH/0kfhr13vlWy4aX8BBBUElJg
VB0HM+pjUmOQt5T47Jrd4fCHqGVlPPpOzneRYl+Jlo+eunLb0OJhwHXkkr/HxKYG
9G3LjWwJhFZOuFgzq3s2+waLasEFqmZZAkq+HAyOVmXXdmnm+qmRSsEA1H8cQi8b
Lj/JXOqHKpqeanmtu099nKrot8KAd8KGVK1N2hu1u151Y3+rEJZrSd4SjcMQmu/d
k20iP4L9GCnsTau3KmsrFAclTH7dZR+woo4vd/rKHCSkfK56ubRFJPR8474zxQKw
1khdb7W6KFDULwvIihKRlzI/roEnT83J6uHe9QwJA+WLPvI9mHo8oFwOHotg6kI=
=u3vI
-----END PGP SIGNATURE-----

--nFreZHaLTZJo0R7j--