From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754820AbcJEUvt (ORCPT ); Wed, 5 Oct 2016 16:51:49 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:52477 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751947AbcJEUvs (ORCPT ); Wed, 5 Oct 2016 16:51:48 -0400 Date: Wed, 5 Oct 2016 22:51:42 +0200 From: Pavel Machek To: trivial@kernel.org, marcel@holtmann.org, gustavo@padovan.org, johan.hedberg@gmail.com, davem@davemloft.net, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCHv2] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel Message-ID: <20161005205142.GA26186@amd> References: <20161003085640.GA8130@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua" Content-Disposition: inline In-Reply-To: <20161003085640.GA8130@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --SUOF0GtieIMvvwua Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable bluetooth.h is not part of user API, so __ variants are not neccessary here. Signed-off-by: Pavel Machek --- v2: not touching stuff that Marcel does not want touched, as it will become API later. diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/blue= tooth.h index bfd1590..aea0371 100644 --- a/include/net/bluetooth/bluetooth.h +++ b/include/net/bluetooth/bluetooth.h @@ -196,7 +196,7 @@ typedef struct { #define BDADDR_LE_PUBLIC 0x01 #define BDADDR_LE_RANDOM 0x02 =20 -static inline bool bdaddr_type_is_valid(__u8 type) +static inline bool bdaddr_type_is_valid(u8 type) { switch (type) { case BDADDR_BREDR: @@ -208,7 +208,7 @@ static inline bool bdaddr_type_is_valid(__u8 type) return false; } =20 -static inline bool bdaddr_type_is_le(__u8 type) +static inline bool bdaddr_type_is_le(u8 type) { switch (type) { case BDADDR_LE_PUBLIC: @@ -278,15 +278,16 @@ struct sock *bt_accept_dequeue(struct sock *parent, s= truct socket *newsock); =20 /* Skb helpers */ struct l2cap_ctrl { - __u8 sframe:1, + u8 sframe:1, poll:1, final:1, fcs:1, sar:2, super:2; - __u16 reqseq; - __u16 txseq; - __u8 retries; + + u16 reqseq; + u16 txseq; + u8 retries; __le16 psm; bdaddr_t bdaddr; struct l2cap_chan *chan; @@ -302,7 +303,7 @@ typedef void (*hci_req_complete_skb_t)(struct hci_dev *= hdev, u8 status, #define HCI_REQ_SKB BIT(1) =20 struct hci_ctrl { - __u16 opcode; + u16 opcode; u8 req_flags; u8 req_event; union { @@ -312,10 +313,10 @@ struct hci_ctrl { }; =20 struct bt_skb_cb { - __u8 pkt_type; - __u8 force_active; - __u16 expect; - __u8 incoming:1; + u8 pkt_type; + u8 force_active; + u16 expect; + u8 incoming:1; union { struct l2cap_ctrl l2cap; struct hci_ctrl hci; @@ -365,7 +366,7 @@ out: return NULL; } =20 -int bt_to_errno(__u16 code); +int bt_to_errno(u16 code); =20 void hci_sock_set_flag(struct sock *sk, int nr); void hci_sock_clear_flag(struct sock *sk, int nr); --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --SUOF0GtieIMvvwua Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlf1Z94ACgkQMOfwapXb+vIrfQCfTgFZSZ1SATElWbTAqsn868N8 3lEAn16mFFPyUpfTAwLAun2tmIv89QmJ =3hP3 -----END PGP SIGNATURE----- --SUOF0GtieIMvvwua--