All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: alexandre.sidorenko@hpe.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net v2] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion
Date: Fri, 07 Oct 2016 23:51:00 -0400 (EDT)	[thread overview]
Message-ID: <20161007.235100.1185623091934128288.davem@davemloft.net> (raw)
In-Reply-To: <14617987.qnk3Z4yzn3@zbook>

From: Alex Sidorenko <alexandre.sidorenko@hpe.com>
Date: Fri, 07 Oct 2016 09:02:33 -0400

> Roundrobin runner of team driver uses 'unsigned int' variable to count
> the number of sent_packets. Later it is passed to a subroutine
> team_num_to_port_index(struct team *team, int num) as 'num' and when
> we reach MAXINT (2**31-1), 'num' becomes negative.
> 
> This leads to using incorrect hash-bucket for port lookup
> and as a result, packets are dropped. The fix consists of changing 
> 'int num' to 'unsigned int num'. Testing of a fixed kernel shows that
> there is no packet drop anymore.
> 
> 
> Signed-off-by: Alex Sidorenko <alexandre.sidorenko@hpe.com>

Applied and queued up for -stable, thanks.

      reply	other threads:[~2016-10-08  3:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 13:02 [PATCH net v2] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion Alex Sidorenko
2016-10-08  3:51 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161007.235100.1185623091934128288.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexandre.sidorenko@hpe.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.