From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-5.5 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 1BE2120986 for ; Fri, 7 Oct 2016 14:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756016AbcJGOUq (ORCPT ); Fri, 7 Oct 2016 10:20:46 -0400 Received: from cloud.peff.net ([104.130.231.41]:53924 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754082AbcJGOUp (ORCPT ); Fri, 7 Oct 2016 10:20:45 -0400 Received: (qmail 29344 invoked by uid 109); 7 Oct 2016 14:20:44 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Fri, 07 Oct 2016 14:20:44 +0000 Received: (qmail 5686 invoked by uid 111); 7 Oct 2016 14:21:02 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Fri, 07 Oct 2016 10:21:02 -0400 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Fri, 07 Oct 2016 10:20:42 -0400 Date: Fri, 7 Oct 2016 10:20:42 -0400 From: Jeff King To: Johannes Schindelin Cc: Duy Nguyen , Junio C Hamano , Git Mailing List Subject: Re: [PATCH/RFC] git.c: support "!!" aliases that do not move cwd Message-ID: <20161007142041.7xjqgujma5w6f77h@sigill.intra.peff.net> References: <20161006114124.4966-1-pclouds@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Oct 07, 2016 at 04:11:34PM +0200, Johannes Schindelin wrote: > Possibly a better idea would be to use *another* special symbol, one that > makes intuitive sense as a modifier, such as: > > [alias] > # This works as before > xyz = !pwd > # As does this > stat = -p status > # This, however, is different: > duy = (nocd)!pwd > > This is backwards compatible as "(" is not a part of any Git command, nor > of a valid alias, nor is it commonly used as part of a git-* > executable/script. > > It is also kind of a bit more intuitive, I'd wager, and it is also > extensible to future options we may want to introduce. I like this much better (like you, I am concerned about things like "!(foo)" as conflicting with the shell). And I think your "(nocd)!pwd" example is quite readable. -Peff