All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Elizabeth Ferdman <gnudevliz@gmail.com>
Cc: outreachy-kernel@googlegroups.com, amsfield22@gmail.com,
	daniel.baluta@intel.com, sudipm.mukherjee@gmail.com,
	teddy.wang@siliconmotion.com
Subject: Re: [PATCH v2] staging: sm750fb: replace macro with builtin fn
Date: Fri, 7 Oct 2016 16:59:36 +0200	[thread overview]
Message-ID: <20161007145936.GA8908@kroah.com> (raw)
In-Reply-To: <20161002223356.GA5653@localhost>

On Sun, Oct 02, 2016 at 03:33:59PM -0700, Elizabeth Ferdman wrote:
> Drop a local macro definition and replace its uses with a standard
> macro function from linux/kernel.h: DIV_ROUND_CLOSEST, to avoid
> reproducing code.
> 
> Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com>
> ---
> Changes in v2:
>  - Use "with" not w in the subject line 
>  - Specify the name of the builtin macro in the description
>  - Explain why this change is necessary

Someone else already sent this patch in and got it accepted before you
did, sorry.

greg k-h


  reply	other threads:[~2016-10-07 14:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-02 22:33 [PATCH v2] staging: sm750fb: replace macro with builtin fn Elizabeth Ferdman
2016-10-07 14:59 ` Greg KH [this message]
2016-10-07 22:32   ` Elizabeth Ferdman
2016-10-09 14:35     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161007145936.GA8908@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amsfield22@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=gnudevliz@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.