From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bslCN-0002sU-NT for qemu-devel@nongnu.org; Sat, 08 Oct 2016 02:33:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bslCK-0000mc-IW for qemu-devel@nongnu.org; Sat, 08 Oct 2016 02:33:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bslCK-0000mO-C8 for qemu-devel@nongnu.org; Sat, 08 Oct 2016 02:33:28 -0400 Date: Sat, 8 Oct 2016 14:33:22 +0800 From: Peter Xu Message-ID: <20161008063322.GE3666@pxdev.xzpeter.org> References: <20161005130657.3399-1-rkrcmar@redhat.com> <20161005130657.3399-2-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161005130657.3399-2-rkrcmar@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 1/8] apic: add global apic_get_class() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: qemu-devel@nongnu.org, Igor Mammedov , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" On Wed, Oct 05, 2016 at 03:06:50PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99 wro= te: > Every configuration has only up to one APIC class and we'll be extendin= g > the class with a function that can be called without an instanced > object, so a direct access to the class is convenient. >=20 > This patch will break compilation if some code uses apic_get_class() > with CONFIG_USER_ONLY. >=20 > Suggested-by: Eduardo Habkost > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 Reviewed-by: Peter Xu