From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bslOH-000698-Oa for qemu-devel@nongnu.org; Sat, 08 Oct 2016 02:45:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bslOB-0007Yr-Nm for qemu-devel@nongnu.org; Sat, 08 Oct 2016 02:45:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bslOB-0007YY-HS for qemu-devel@nongnu.org; Sat, 08 Oct 2016 02:45:43 -0400 Date: Sat, 8 Oct 2016 14:45:38 +0800 From: Peter Xu Message-ID: <20161008064538.GH3666@pxdev.xzpeter.org> References: <20161005130657.3399-1-rkrcmar@redhat.com> <20161005130657.3399-5-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161005130657.3399-5-rkrcmar@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 4/8] intel_iommu: redo configuraton check in realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: qemu-devel@nongnu.org, Igor Mammedov , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" On Wed, Oct 05, 2016 at 03:06:53PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99 wro= te: > * there no point in configuring the device if realization is going to > fail, so move the check to the beginning, > * create a separate function for the check, > * use error_setg() instead error_report(). >=20 > Reviewed-by: Igor Mammedov > Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 Reviewed-by: Peter Xu