All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 4/4 v2] staging: wilc1000: Move externs from .c to .h files.
@ 2016-10-08 17:58 Elise Lennion
  2016-10-10  7:49 ` [Outreachy kernel] " Arnd Bergmann
  0 siblings, 1 reply; 2+ messages in thread
From: Elise Lennion @ 2016-10-08 17:58 UTC (permalink / raw)
  To: aditya.shankar, ganesh.krishna, gregkh, outreachy-kernel

Fix checkpatch warning:

WARNING: externs should be avoided in .c files

The externs were removed because there are already declarations in wilc_wlan.h for them.

Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
---
 drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
index fca96d3..a5e2d96 100644
--- a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
+++ b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
@@ -90,9 +90,6 @@ static const struct wiphy_wowlan_support wowlan_support = {
 #define IS_MGMT_STATUS_SUCCES			0x040
 #define GET_PKT_OFFSET(a) (((a) >> 22) & 0x1ff)
 
-extern int wilc_mac_open(struct net_device *ndev);
-extern int wilc_mac_close(struct net_device *ndev);
-
 static struct network_info last_scanned_shadow[MAX_NUM_SCANNED_NETWORKS_SHADOW];
 static u32 last_scanned_cnt;
 struct timer_list wilc_during_ip_timer;
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH 4/4 v2] staging: wilc1000: Move externs from .c to .h files.
  2016-10-08 17:58 [PATCH 4/4 v2] staging: wilc1000: Move externs from .c to .h files Elise Lennion
@ 2016-10-10  7:49 ` Arnd Bergmann
  0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2016-10-10  7:49 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: Elise Lennion, aditya.shankar, ganesh.krishna, gregkh

On Saturday, October 8, 2016 2:58:51 PM CEST Elise Lennion wrote:
> Fix checkpatch warning:
> 
> WARNING: externs should be avoided in .c files
> 
> The externs were removed because there are already declarations in wilc_wlan.h for them.
> 
> Signed-off-by: Elise Lennion <elise.lennion@gmail.com>

Acked-by: Arnd Bergmann <arnd@arndb.de>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-10  7:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-08 17:58 [PATCH 4/4 v2] staging: wilc1000: Move externs from .c to .h files Elise Lennion
2016-10-10  7:49 ` [Outreachy kernel] " Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.