From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v2 2/4] ACPI / gpio: Add support for naming GPIOs Date: Sun, 9 Oct 2016 18:01:27 +0300 Message-ID: <20161009150127.GY30800@lahna.fi.intel.com> References: <20160929133944.158596-1-mika.westerberg@linux.intel.com> <20160929133944.158596-3-mika.westerberg@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga03.intel.com ([134.134.136.65]:20425 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbcJIPBh (ORCPT ); Sun, 9 Oct 2016 11:01:37 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Andy Shevchenko Cc: "Rafael J. Wysocki" , Linus Walleij , Alexandre Courbot , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Fri, Oct 07, 2016 at 08:05:14PM +0300, Andy Shevchenko wrote: > On Thu, Sep 29, 2016 at 4:39 PM, Mika Westerberg > wrote: > > DT has property 'gpio-line-names' to name GPIO lines the controller has if > > present. Use this very same property in ACPI as well to provide nice names > > for the GPIOS. > > One nit below. > > > @@ -835,6 +875,9 @@ void acpi_gpiochip_add(struct gpio_chip *chip) > > return; > > } > > > > + if (!chip->names) > > + acpi_gpiochip_set_names(acpi_gpio); > > + > > I'm okay with this, though wouldn't be better to call it > unconditionally like it's done for below call and move check inside? DT does it like this. I can move the check inside the function as well. > > > acpi_gpiochip_request_regions(acpi_gpio); > > acpi_walk_dep_device_list(handle); > > } > > -- > With Best Regards, > Andy Shevchenko