All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Justin Maggard <jmaggard10@gmail.com>
Cc: David Sterba <dsterba@suse.com>,
	BTRFS <linux-btrfs@vger.kernel.org>, Chris Mason <clm@fb.com>
Subject: Re: Btrfs progs pre-release 4.8.1-rc1
Date: Sun, 9 Oct 2016 22:40:04 +0200	[thread overview]
Message-ID: <20161009204004.GH11398@twin.jikos.cz> (raw)
In-Reply-To: <CAKgsxVQsy4E0HVUPK3jYum75GyMvuui_sAVOkzDeAAL8f1zUtQ@mail.gmail.com>

On Fri, Oct 07, 2016 at 12:57:58PM -0700, Justin Maggard wrote:
> This is falling over on my 32-bit ARM platform.  Using stock Debian
> Jessie armel or armhf, it builds now, but the send ioctl is unhappy:
> 
> # btrfs send -p /data/test/.snapshots/1/snapshot/
> /data/test/.snapshots/2/snapshot/ > /dev/null
> At subvol /data/test/.snapshots/2/snapshot/
> ERROR: send ioctl failed with -25: Inappropriate ioctl for device
> 
> If I remove the packed attribute from the btrfs_ioctl_send_args struct
> and change the BUILD_ASSERT to expect a 72-byte structure, it all
> starts working again.  I'm using a 4.1 kernel built with the standard
> armhf toolchain from Wheezy (gcc 4.7.2).

Thanks for the report, I think I'll drop the additional changes and
release just the build fixes. We'd need to validate that all ioctls
really work on the target build architecture. The potential explanation
for the problem you found is that 32bit arm has 4 byte pointers but
needs 8 byte alignment.

      reply	other threads:[~2016-10-09 20:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 12:26 Btrfs progs pre-release 4.8.1-rc1 David Sterba
2016-10-07 19:57 ` Justin Maggard
2016-10-09 20:40   ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161009204004.GH11398@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=jmaggard10@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.