From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btNb3-0000M9-0G for qemu-devel@nongnu.org; Sun, 09 Oct 2016 19:33:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btNaz-0003pV-PW for qemu-devel@nongnu.org; Sun, 09 Oct 2016 19:33:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btNaz-0003ox-JU for qemu-devel@nongnu.org; Sun, 09 Oct 2016 19:33:29 -0400 Date: Mon, 10 Oct 2016 02:33:27 +0300 From: "Michael S. Tsirkin" Message-ID: <20161010023246-mutt-send-email-mst@kernel.org> References: <20161005130657.3399-1-rkrcmar@redhat.com> <20161005130657.3399-8-rkrcmar@redhat.com> <20161006145142.GR3877@thinpad.lan.raisama.net> <20161006160051.GC19924@potion> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161006160051.GC19924@potion> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: Eduardo Habkost , qemu-devel@nongnu.org, Peter Xu , Igor Mammedov , Paolo Bonzini , Richard Henderson On Thu, Oct 06, 2016 at 06:00:52PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99 wro= te: > 2016-10-06 11:51-0300, Eduardo Habkost: > > On Wed, Oct 05, 2016 at 03:06:56PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99= wrote: > >> Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 > >> --- > >> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c > >> @@ -2015,6 +2015,7 @@ static Property vtd_properties[] =3D { > >> DEFINE_PROP_UINT32("version", IntelIOMMUState, version, 0), > >> DEFINE_PROP_ON_OFF_AUTO("eim", IntelIOMMUState, intr_eim, > >> ON_OFF_AUTO_AUTO), > >> + DEFINE_PROP_BOOL("buggy_eim", IntelIOMMUState, buggy_eim, false= ), > >=20 > > I suggest "buggy-eim", to follow the usual style for QOM property > > names. > >=20 > > Assuming the name gets changed: > >=20 > > Reviewed-by: Eduardo Habkost >=20 > I'll change the name to "x-buggy-eim" and also squash the patch with > [6/8] as the property doesn't seem to be hated too much. >=20 > It's going to be a different patch, so I'll drop the r-b by default, > sorry. You don't have to drop the r-b if the change is mechanical or minor. Anyway, waiting for the next version. --=20 MST