From: Peter Xu <peterx@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 6/8] intel_iommu: reject broken EIM
Date: Tue, 11 Oct 2016 07:53:23 +0800 [thread overview]
Message-ID: <20161010235323.GE30787@pxdev.xzpeter.org> (raw)
In-Reply-To: <20161010151119.GB30525@potion>
On Mon, Oct 10, 2016 at 05:11:19PM +0200, Radim Krčmář wrote:
[...]
> > But that's really a matter of taste. So:
>
> I'll currently go for an implicit else: (because 4 levels of indentation
> are getting helper-function worthy and it has less curly braces)
>
> if (!kvm_irqchip_in_kernel()) {
> error("need split irqchip");
> return false;
> }
> if (!kvm_enable_x2apic()) {
> error("enable x2apic failed");
> return false;
> }
Good to me.
>
> > Reviewed-by: Peter Xu <peterx@redhat.com>
>
> I squashed [7/8] into this patch in v5 and the second one didn't have
> your r-b, so I made the change as I'd have to drop the r-b anyway.
Sure. Thanks,
-- peterx
next prev parent reply other threads:[~2016-10-10 23:53 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 13:06 [Qemu-devel] [PATCH v4 0/8] intel_iommu: fix EIM Radim Krčmář
2016-10-05 13:06 ` [Qemu-devel] [PATCH v4 1/8] apic: add global apic_get_class() Radim Krčmář
2016-10-06 14:40 ` Eduardo Habkost
2016-10-08 6:33 ` Peter Xu
2016-10-05 13:06 ` [Qemu-devel] [PATCH v4 2/8] apic: add send_msi() to APICCommonClass Radim Krčmář
2016-10-08 6:37 ` Peter Xu
2016-10-09 20:54 ` Michael S. Tsirkin
2016-10-10 13:35 ` Radim Krčmář
2016-10-10 23:50 ` Peter Xu
2016-10-05 13:06 ` [Qemu-devel] [PATCH v4 3/8] intel_iommu: pass whole remapped addresses to apic Radim Krčmář
2016-10-07 13:05 ` Igor Mammedov
2016-10-07 16:24 ` Radim Krčmář
2016-10-08 6:14 ` Peter Xu
2016-10-08 6:23 ` Peter Xu
2016-10-10 13:16 ` Igor Mammedov
2016-10-08 6:43 ` Peter Xu
2016-10-05 13:06 ` [Qemu-devel] [PATCH v4 4/8] intel_iommu: redo configuraton check in realize Radim Krčmář
2016-10-08 6:45 ` Peter Xu
2016-10-05 13:06 ` [Qemu-devel] [PATCH v4 5/8] intel_iommu: add OnOffAuto intr_eim as "eim" property Radim Krčmář
2016-10-08 7:13 ` Peter Xu
2016-10-05 13:06 ` [Qemu-devel] [PATCH v4 6/8] intel_iommu: reject broken EIM Radim Krčmář
2016-10-08 7:21 ` Peter Xu
2016-10-10 15:11 ` Radim Krčmář
2016-10-10 23:53 ` Peter Xu [this message]
2016-10-05 13:06 ` [Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type Radim Krčmář
2016-10-06 14:51 ` Eduardo Habkost
2016-10-06 15:33 ` Michael S. Tsirkin
2016-10-06 15:55 ` Radim Krčmář
2016-10-10 17:46 ` [Qemu-devel] Deprecating old machine-types (was Re: [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type) Eduardo Habkost
2016-10-11 7:36 ` Paolo Bonzini
2016-10-11 8:23 ` Daniel P. Berrange
2016-10-11 8:47 ` Paolo Bonzini
2016-10-14 14:50 ` Eduardo Habkost
2016-10-06 16:00 ` [Qemu-devel] [PATCH v4 7/8] intel_iommu: keep buggy EIM enabled in 2.7 machine type Radim Krčmář
2016-10-09 23:33 ` Michael S. Tsirkin
2016-10-05 13:06 ` [Qemu-devel] [PATCH v4 8/8] target-i386/kvm: cache the return value of kvm_enable_x2apic() Radim Krčmář
2016-10-07 13:01 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010235323.GE30787@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.