All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] lsmod01: parse a copy of /proc/modules
Date: Tue, 11 Oct 2016 15:38:24 +0200	[thread overview]
Message-ID: <20161011133824.GA17083@rei.suse.cz> (raw)
In-Reply-To: <57FCD515.20202@oracle.com>

Hi!
> Tried this all again.
> 
> This is from a 4.1-based kernel in a VirtualBox host:
> 
> [root@ol6-x64 mnt]# mount|grep mnt
> 127.0.0.1:/opt/ on /mnt type nfs (rw,vers=3,addr=127.0.0.1)
> [root@ol6-x64 mnt]# grep sunrpc /proc/modules
> sunrpc 329262 28
> nfsv3,rpcsec_gss_krb5,nfsv4,nfs,nfsd,lockd,nfs_acl,auth_rpcgss, Live
> 0xffffffffa0366000
> [root@ol6-x64 mnt]# dd if=/dev/zero of=file bs=512
> 
> While the above dd command is running, in a separate shell I see:
> 
> [stas@ol6-x64 ~]$ lsmod|grep sunrpc
> sunrpc                329262  36
> nfsv3,rpcsec_gss_krb5,nfsv4,nfs,nfsd,lockd,nfs_acl,auth_rpcgss
> [stas@ol6-x64 ~]$

Hmm, 36, really increased by 8 because of the one dd?

That sounds even more strange.

> [root@ol6-x64 mnt]# grep sunrpc /proc/modules
> sunrpc 329262 28
> nfsv3,rpcsec_gss_krb5,nfsv4,nfs,nfsd,lockd,nfs_acl,auth_rpcgss, Live
> 0xffffffffa0366000
> [root@ol6-x64 mnt]# dd if=/proc/modules bs=1 | cat > temp2; grep sunrpc
> temp2
> 2564+0 records in
> 2564+0 records out
> 2564 bytes (2.6 kB) copied, 0.00313203 s, 819 kB/s
> sunrpc 329262 29
> nfsv3,rpcsec_gss_krb5,nfsv4,nfs,nfsd,lockd,nfs_acl,auth_rpcgss, Live
> 0xffffffffa0366000
> [root@ol6-x64 mnt]#
> 
> The same situation is with NFSv4.
> 
> So it turns out that writing to a file on NFS increases the sunrpc
> module reference counter. I don't observe this with ext4.ko.
> 
> So I find that my original patch is fine, it just needs a proper
> description.
> 
> Thoughts?

Isn't the original patch just workaround? Since we write to the nfs
TMPDIR as well, just differently, there is always possibility that we
only made the problem less probable and that it will fail in one of
thousand runs. Have you tried to run the test in a loop for some time?

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2016-10-11 13:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29 11:08 [LTP] [PATCH] lsmod01: parse a copy of /proc/modules Stanislav Kholmanskikh
2016-08-29 12:50 ` Cyril Hrubis
2016-08-29 13:05   ` Stanislav Kholmanskikh
2016-08-29 13:34     ` Jan Stancek
2016-08-29 14:00       ` Stanislav Kholmanskikh
2016-08-29 14:03         ` Stanislav Kholmanskikh
2016-08-29 15:17           ` Cyril Hrubis
2016-08-29 15:49           ` Jan Stancek
2016-10-11 12:03             ` Stanislav Kholmanskikh
2016-10-11 13:38               ` Cyril Hrubis [this message]
2016-10-11 15:47                 ` Stanislav Kholmanskikh
2016-10-11 16:15                   ` Cyril Hrubis
2016-11-09 14:34                     ` [LTP] [PATCH] lsmod01: keep the output in variables Stanislav Kholmanskikh
2016-11-09 16:49                       ` Cyril Hrubis
2016-11-10 10:07                         ` Stanislav Kholmanskikh
2016-11-10 11:39                           ` Cyril Hrubis
2016-11-10 14:15                             ` Stanislav Kholmanskikh
2016-08-31 13:55 ` [LTP] [PATCH] lsmod01: parse a copy of /proc/modules Cyril Hrubis
2016-09-02 14:12   ` Stanislav Kholmanskikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161011133824.GA17083@rei.suse.cz \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.