From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59954)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1buF87-0004B9-4U
	for qemu-devel@nongnu.org; Wed, 12 Oct 2016 04:43:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1buF85-0000Vn-7l
	for qemu-devel@nongnu.org; Wed, 12 Oct 2016 04:43:14 -0400
Date: Wed, 12 Oct 2016 10:43:03 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20161012084303.GC5544@noname.redhat.com>
References: <1476171437-11830-1-git-send-email-ashijeetacharya@gmail.com>
	<CAC2QTZYZRUgq2-S9G2qY3mGOQ5o7T7B11v=zebowMAzRSkjXsw@mail.gmail.com>
	<20161012082254.GA5544@noname.redhat.com>
	<CAC2QTZaE2XRGTqYxvuDHEfg5ro0BZsSnHfR=puj0tPnDaVVu7g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAC2QTZaE2XRGTqYxvuDHEfg5ro0BZsSnHfR=puj0tPnDaVVu7g@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: "Richard W.M. Jones" <rjones@redhat.com>, jcody@redhat.com, Eric Blake <eblake@redhat.com>, mreitz@redhat.com, armbru@redhat.com, QEMU Developers <qemu-devel@nongnu.org>, qemu-block@nongnu.org

Am 12.10.2016 um 10:37 hat Ashijeet Acharya geschrieben:
> On Wed, Oct 12, 2016 at 1:52 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> > Am 12.10.2016 um 10:09 hat Ashijeet Acharya geschrieben:
> 
> > Of course, we must be able to build qemu correctly both with ssh enabled
> > and disabled, so if you can indeed see a (different) build error with
> > disabled libssh2, that needs to be fixed.
> 
> I am able to reproduce it when I don't apply Dan's patch with libssh2 enabled.
> After disabling libssh2, it compiles perfectly because then the SSH
> driver will get ignored I guess.
> libssh2 doesn't seem to be the problem.
> 
> >
> > But I can't see how that would happen, you don't touch configure and it
> > already compiled the ssh driver out if libssh2 is disabled.
> 
> Yes, with libssh2 disabled it builds with no error just like the first
> output of auto-build shows.
> So, I think with libssh2 enabled it throws an error (just like second
> output of auto-build) since Dan's patches are not merged yet. Right?

Yes. You can ignore that, we'll make sure to merge the patches in the
right order.

Kevin