From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44995) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1buMZm-0008P9-9i for qemu-devel@nongnu.org; Wed, 12 Oct 2016 12:40:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1buMZl-0005GY-8X for qemu-devel@nongnu.org; Wed, 12 Oct 2016 12:40:18 -0400 Date: Wed, 12 Oct 2016 18:40:06 +0200 From: Kevin Wolf Message-ID: <20161012164006.GR5544@noname.redhat.com> References: <1476171437-11830-1-git-send-email-ashijeetacharya@gmail.com> <20161012160106.GP5544@noname.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 0/4] Allow blockdev-add for SSH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya Cc: "Richard W.M. Jones" , jcody@redhat.com, Eric Blake , mreitz@redhat.com, armbru@redhat.com, QEMU Developers , qemu-block@nongnu.org Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben: > On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf wrote: > > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: > >> This series adds blockdev-add support for SSH block driver. > >> > >> Patch 1 prepares the code for the addition of a new option prefix, > >> which is "server.". This is accomplished by adding a > >> ssh_has_filename_options_conflict() function which helps to iterate > >> over the various options and check for conflict. > >> > >> Patch 2 first adds InetSocketAddress compatibility to SSH block driver > >> and then makes it accept a InetSocketAddress under the "server" option. > >> The old options "host" and "port" are supported as legacy options and > >> then translated to the respective InetSocketAddress representation. > >> > >> Patch 3 drops the usage of "host" and "port" outside of > >> ssh_has_filename_options_conflict() and > >> ssh_process_legacy_socket_options() functions in order to make them > >> legacy options completely. > >> > >> Patch 4 helps to allow blockdev-add support for the SSH block driver > >> by making the SSH option available. > > > > Commented on patch 2, the rest looks good to me at first sight. > > Yes, I am going through that currently and will ask you if I have any queries. > > > > > Just curious, what kind of testing did you give the series? > > First thing I made sure if I wasn't breaking anything. Basically I > checked if blockdev-add worked with it and then if I am able to remove > it with x-blockdev-del. Did you try out all of the options that we support, including those in InetSocketAddress? > Also, there were no major changes which could > make the patches to break. I don't see tests available for SSH either > so there was nothing much I can do. > Do you have anything in mind? Actually, qemu-iotests has ssh support. It's probably not run very often, so I'm not sure whether it completely passes on master, but worth a try anyway. Check out ./check --help in tests/qemu-iotests, you'll probably want something like './check -T -ssh'. The commit message that added ssh support to the tests says: Note in order to run these tests on ssh, you must be running a local ssh daemon, and that daemon must accept loopback connections, and ssh-agent has to be set up to allow logins on the local daemon. In other words, the following command should just work without demanding any passphrase: ssh localhost Hope this is helpful. Kevin