From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753890AbcJMK2K (ORCPT ); Thu, 13 Oct 2016 06:28:10 -0400 Received: from mga06.intel.com ([134.134.136.31]:41494 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753676AbcJMK1z (ORCPT ); Thu, 13 Oct 2016 06:27:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,339,1473145200"; d="scan'208";a="1069873444" Date: Thu, 13 Oct 2016 13:24:45 +0300 From: Mika Westerberg To: Benjamin Tissoires Cc: Jiri Kosina , David Arcari , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Revert "HID: i2c-hid: Add support for ACPI GPIO interrupts" Message-ID: <20161013102445.GP2774@lahna.fi.intel.com> References: <1476351045-8829-1-git-send-email-benjamin.tissoires@redhat.com> <1476351045-8829-2-git-send-email-benjamin.tissoires@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476351045-8829-2-git-send-email-benjamin.tissoires@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 13, 2016 at 11:30:44AM +0200, Benjamin Tissoires wrote: > From: David Arcari > > This reverts commit a485923efbb8 ("HID: i2c-hid: Add support for ACPI > GPIO interrupts") and commit a7d2bf25a483 ("HID: i2c-hid: Do not fail > probing if gpiolib is not enabled") at the same time. > > Since commit c884fbd45214 ("gpio / ACPI: Add support for retrieving > GpioInt resources from a device") i2c_core already set the IRQ by > looking into the ACPI tree and retrieving the gpioInt. So we just > have some boiler-plate here that is not needed anymore. > > The only downside effect here is that now we are not exiting early > enough if the irq is set to -EPROBE_DEFER or any other error, but > this is going to be fixed in the following patch. > > Signed-off-by: David Arcari > Signed-off-by: Benjamin Tissoires I went through my collection of ACPI dumps from different machines and I did not find anything using plain GpioIo() resource. So I think this should be safe thing to do. Reviewed-by: Mika Westerberg