From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bueIj-0002fZ-Sq for qemu-devel@nongnu.org; Thu, 13 Oct 2016 07:35:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bueIi-0002qN-Vs for qemu-devel@nongnu.org; Thu, 13 Oct 2016 07:35:53 -0400 Date: Thu, 13 Oct 2016 13:35:45 +0200 From: Kevin Wolf Message-ID: <20161013113545.GF5803@noname.redhat.com> References: <20160928205602.17275-1-mreitz@redhat.com> <20160928205602.17275-6-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160928205602.17275-6-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 05/12] block/nbd: Add nbd_has_filename_options_conflict() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Eric Blake , Paolo Bonzini , Markus Armbruster Am 28.09.2016 um 22:55 hat Max Reitz geschrieben: > Right now, we have four possible options that conflict with specifying > an NBD filename, and a future patch will add another one ("address"). > This future option is a nested QDict that is flattened at this point, > requiring us to test each option whether its key has an "address." > prefix. Therefore, we will then need to iterate through all options. > > Adding this iteration logic now will simplify adding the new option > later. A nice side effect is that the user will not receive a long list > of five options which are not supposed to be specified with a filename, > but we can actually print the problematic option. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf