From: Daniel Vetter <daniel@ffwll.ch>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 0/8] HuC Loading Patches
Date: Thu, 13 Oct 2016 15:10:53 +0200 [thread overview]
Message-ID: <20161013131053.GM20761@phenom.ffwll.local> (raw)
In-Reply-To: <1475172245-10939-1-git-send-email-anusha.srivatsa@intel.com>
On Thu, Sep 29, 2016 at 11:03:57AM -0700, Anusha Srivatsa wrote:
> These patches add HuC loading support. The userspace
> patches that check for a fully loaded HuC firmware and use
> it can be found at:
> https://lists.freedesktop.org/archives/libva/2016-September/004554.html
> https://lists.freedesktop.org/archives/libva/2016-September/004555.html
>
> Peter Antoine (8):
> drm/i915/guc: Make the GuC fw loading helper functions general
> drm/i915/huc: Unified css_header struct for GuC and HuC
> drm/i915/huc: Add HuC fw loading support
> drm/i915/huc: Add debugfs for HuC loading status check
> drm/i915/huc: Support HuC authentication
> drm/i915/huc: Add BXT HuC Loading Support
> drm/i915/get_params: Add GuC status to getparams
> drm/i915/get_params: Add HuC status to getparams
So trouble with these is that both original authors (all of them) and
reviewers left intel. Which means we don't have anyone anymore who
understands this, and a big part of review is making sure that in the end
at least two people (author+reviewer) really understand the patches in
full detail.
In short we need to restart the review process here again before merging
:(
-Daniel
>
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/i915_debugfs.c | 43 ++++-
> drivers/gpu/drm/i915/i915_drv.c | 11 ++
> drivers/gpu/drm/i915/i915_drv.h | 3 +
> drivers/gpu/drm/i915/i915_guc_reg.h | 3 +
> drivers/gpu/drm/i915/i915_guc_submission.c | 69 ++++++-
> drivers/gpu/drm/i915/intel_guc.h | 46 +++--
> drivers/gpu/drm/i915/intel_guc_fwif.h | 17 +-
> drivers/gpu/drm/i915/intel_guc_loader.c | 215 ++++++++++++---------
> drivers/gpu/drm/i915/intel_huc.h | 44 +++++
> drivers/gpu/drm/i915/intel_huc_loader.c | 289 +++++++++++++++++++++++++++++
> include/uapi/drm/i915_drm.h | 2 +
> 12 files changed, 623 insertions(+), 120 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/intel_huc.h
> create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c
>
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-10-13 13:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 18:03 [PATCH 0/8] HuC Loading Patches Anusha Srivatsa
2016-09-29 18:03 ` [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general Anusha Srivatsa
2016-09-29 18:03 ` [PATCH 2/8] drm/i915/huc: Unified css_header struct for GuC and HuC Anusha Srivatsa
2016-09-29 18:04 ` [PATCH 3/8] drm/i915/huc: Add HuC fw loading support Anusha Srivatsa
2016-09-29 18:04 ` [PATCH 4/8] drm/i915/huc: Add debugfs for HuC loading status check Anusha Srivatsa
2016-09-29 18:04 ` [PATCH 5/8] drm/i915/huc: Support HuC authentication Anusha Srivatsa
2016-09-29 18:04 ` [PATCH 6/8] drm/i915/huc: Add BXT HuC Loading Support Anusha Srivatsa
2016-09-29 18:04 ` [PATCH 7/8] drm/i915/get_params: Add GuC status to getparams Anusha Srivatsa
2016-09-29 18:04 ` [PATCH 8/8] drm/i915/get_params: Add HuC " Anusha Srivatsa
2016-09-29 18:31 ` ✗ Fi.CI.BAT: failure for HuC Loading Patches Patchwork
2016-10-13 13:10 ` Daniel Vetter [this message]
2016-10-03 18:42 [PATCH 0/8] " Anusha Srivatsa
2016-10-07 7:09 ` Daniel Vetter
2016-11-23 22:27 Anusha Srivatsa
2016-11-25 14:40 ` Arkadiusz Hiler
2016-11-30 23:31 Anusha Srivatsa
2016-12-08 23:02 [PATCH 0/8]HuC " anushasr
2016-12-15 22:29 [PATCH 0/8] HuC " anushasr
2016-12-22 23:12 Anusha Srivatsa
2017-01-04 13:27 Anusha Srivatsa
2017-01-04 14:55 Anusha Srivatsa
2017-01-13 14:26 Anusha Srivatsa
2017-01-13 16:40 Anusha Srivatsa
2017-01-13 17:03 Anusha Srivatsa
2017-01-16 9:27 ` Jani Nikula
2017-01-16 9:45 ` Jani Nikula
2017-01-13 18:08 Anusha Srivatsa
2017-01-14 1:17 Anusha Srivatsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013131053.GM20761@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=anusha.srivatsa@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.