From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Assert we hold the CRTC powerwell for generating vblank interrupts Date: Thu, 13 Oct 2016 16:17:07 +0200 Message-ID: <20161013141707.GZ20761@phenom.ffwll.local> References: <20161010113454.7249-1-chris@chris-wilson.co.uk> <20161010114201.GB4329@intel.com> <20161010114632.GA16122@nuc-i3427.alporthouse.com> <20161010115640.GC4329@intel.com> <6925210f-e485-64de-e0be-17fe03887924@linux.intel.com> <20161011065538.GL4329@intel.com> <20161011083227.GM4329@intel.com> <6d584334-0af6-6075-817f-31ce6f7b1e79@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-x242.google.com (mail-qk0-x242.google.com [IPv6:2607:f8b0:400d:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 143D66EAA7 for ; Thu, 13 Oct 2016 14:17:11 +0000 (UTC) Received: by mail-qk0-x242.google.com with SMTP id f128so5513096qkb.0 for ; Thu, 13 Oct 2016 07:17:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <6d584334-0af6-6075-817f-31ce6f7b1e79@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTIsIDIwMTYgYXQgMDc6MjE6NDRBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTEtMTAtMTYgb20gMTA6MzIgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBUdWUsIE9jdCAxMSwgMjAxNiBhdCAwOTo0NTo0NUFNICswMjAwLCBNYWFydGVuIExh bmtob3JzdCB3cm90ZToKPiA+PiBPcCAxMS0xMC0xNiBvbSAwODo1NSBzY2hyZWVmIFZpbGxlIFN5 cmrDpGzDpDoKPiA+Pj4gT24gVHVlLCBPY3QgMTEsIDIwMTYgYXQgMDg6MTc6MjJBTSArMDIwMCwg TWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPj4+PiBPcCAxMC0xMC0xNiBvbSAxMzo1NiBzY2hy ZWVmIFZpbGxlIFN5cmrDpGzDpDoKPiA+Pj4+PiBPbiBNb24sIE9jdCAxMCwgMjAxNiBhdCAxMjo0 NjozMlBNICswMTAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gPj4+Pj4+IE9uIE1vbiwgT2N0IDEw LCAyMDE2IGF0IDAyOjQyOjAxUE0gKzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+Pj4+ Pj4+IE9uIE1vbiwgT2N0IDEwLCAyMDE2IGF0IDEyOjM0OjU0UE0gKzAxMDAsIENocmlzIFdpbHNv biB3cm90ZToKPiA+Pj4+Pj4+PiBUbyBlbmFibGUgdGhlIHZibGFuayBpdHNlbGYsIHdlIG5lZWQg dG8gaGF2ZSBhbiBSUE0gd2FrZXJlZiBmb3IgdGhlIG1taW8KPiA+Pj4+Pj4+PiBhY2Nlc3MsIGFu ZCB3aGlsc3QgZ2VuZXJhdGluZyB0aGUgdmJsYW5rIGludGVycnVwdHMgd2UgY29udGludWUgdG8K PiA+Pj4+Pj4+PiByZXF1aXJlIHRoZSBycG0gd2FrZXJlZi4gVGhlIGFzc3VtcHRpb24gaXMgdGhh dCB0aGUgUlBNIHdha2VyZWYgaXMgaGVsZAo+ID4+Pj4+Pj4+IGJ5IHRoZSBkaXNwbGF5IHBvd2Vy d2VsbCBoZWxkIGJ5IHRoZSBhY3RpdmUgcGlwZS4gQXMgdGhpcyBjaGFpbiB3YXMgbm90Cj4gPj4+ Pj4+Pj4gb2J2aW91cyB0byBtZSBjaGFzaW5nIHRoZSBkcm1fd2FpdF92YmxhbmsgaW9jdGwsIGRv Y3VtZW50IGl0IHdpdGggYSBXQVJOCj4gPj4+Pj4+Pj4gZHVyaW5nICpfdmJsYW5rX2VuYWJsZSgp Lgo+ID4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4gdjI6IENoZWNrIHRoZSBkaXNwbGF5IHBvd2VyIHdlbGwg cmF0aGVyIHRoYW4gZGlnZ2luZyBpbnNpZGUgdGhlIGF0b21pYwo+ID4+Pj4+Pj4+IENSVEMgc3Rh dGUuCj4gPj4+Pj4+Pj4KPiA+Pj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiA+Pj4+Pj4+PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+Pj4+Pj4+PiBDYzogTWFhcnRlbiBMYW5r aG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+Pj4+Pj4+PiAtLS0K PiA+Pj4+Pj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYyB8IDIwICsrKysrKysr KysrKysrKysrKysrCj4gPj4+Pj4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCsp Cj4gPj4+Pj4+Pj4KPiA+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+Pj4+Pj4+PiBp bmRleCAxZTQzZmUzMGRhMTEuLmYwZjE3MDU1ZGJiOSAxMDA2NDQKPiA+Pj4+Pj4+PiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPj4+Pj4+Pj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+ID4+Pj4+Pj4+IEBAIC0yNzE1LDYgKzI3MTUsMTQgQEAg dm9pZCBpOTE1X2hhbmRsZV9lcnJvcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4gPj4+Pj4+Pj4gIAlpOTE1X3Jlc2V0X2FuZF93YWtldXAoZGV2X3ByaXYpOwo+ID4+Pj4+Pj4+ ICB9Cj4gPj4+Pj4+Pj4gIAo+ID4+Pj4+Pj4+ICtzdGF0aWMgdm9pZCBhc3NlcnRfcGlwZV9pc19h d2FrZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPj4+Pj4+Pj4gKwkJCQkg ZW51bSBwaXBlIHBpcGUpCj4gPj4+Pj4+Pj4gK3sKPiA+Pj4+Pj4+PiArCVdBUk5fT04oSVNfRU5B QkxFRChDT05GSUdfRFJNX0k5MTVfREVCVUcpICYmCj4gPj4+Pj4+Pj4gKwkJIWludGVsX2Rpc3Bs YXlfcG93ZXJfaXNfZW5hYmxlZChkZXZfcHJpdiwKPiA+Pj4+Pj4+PiArCQkJCQkJUE9XRVJfRE9N QUlOX1BJUEUocGlwZSkpKTsKPiA+Pj4+Pj4+IFVzZXMgYSBtdXRleC4gQW5kIGhhdmluZyBhIHBv d2VyIHdlbGwgZW5hYmxlZCBkb2Vzbid0IG1lYW4gbXVjaC4gSXQKPiA+Pj4+Pj4+IGRvZXNuJ3Qg Z3VhcmFudGVlIHRoYXQgdmJsYW5rcyB3b3JrLgo+ID4+Pj4+PiBJbXBhc3NlLiA6fAo+ID4+Pj4+ Pgo+ID4+Pj4+PiBUaGVyZSBzaG91bGQgYmUgbm8gcG9pbnQgaW4gYW4gZXhwbGljaXQgYXNzZXJ0 X3JwbV93YWtlcmVmIGhlcmUgYXMgdGhlCj4gPj4+Pj4+IHJlZ2lzdGVyIGFjY2VzcyBzaG91bGQg Y2F0Y2ggYW4gZXJyb3IgdGhlcmUuIElzIHRoZXJlIG5vIHNhZmUgd2F5IHdlIGNhbgo+ID4+Pj4+ PiBhc3NlcnQgdGhlIGN1cnJlbnQgc3RhdGUgb2YgdGhlIENSVEMgaXMgY29ycmVjdCBmb3IgZW5h YmxpbmcgdmJsYW5rcz8KPiA+Pj4+PiBjcnRjLT5hY3RpdmUgbWlnaHQgYmUgdGhlIGNsb3Nlc3Qg dGhpbmcsIGlmIHdlIGp1c3QgaWdub3JlIGFueSBsb2NraW5nLgo+ID4+Pj4+IFRob3VnaCBpdCBs b29rcyBsaWtlIHRoYXQgaGFzIGdvbmUgYSBiaXQgbWFkIHRoZXNlIGRheXMsIHdoYXQgd2l0aCBi ZWluZwo+ID4+Pj4+IHNldCBmcm9tIHRoZSAuY3J0Y19lbmFibGUoKSBob29rcyBidXQgZ2V0dGlu ZyBjbGVhcmVkIG91dHNpZGUgdGhlCj4gPj4+Pj4gLmNydGNfZGlzYWJsZSgpIGhvb2tzLgo+ID4+ Pj4+Cj4gPj4+PiBJJ20gdHJ5aW5nIHRvIGtpbGwgY3J0Yy0+YWN0aXZlLgo+ID4+PiBCZWNhdXNl IGl0J3MgZXZpbD8gSSBzdGlsbCBkb24ndCBzZWUgbXVjaCBwcm9ibGVtIGluIGhhdmluZyBhIHRo aW5nIHRvCj4gPj4+IHRyYWNrIHRoZSBzdGF0ZSBvZiBlYWNoIHBpcGUgZmFpcmx5IGFjY3VyYXRl bHkuCj4gPj4+Cj4gPj4+PiBNYXliZSB5b3UnZCB3YW50IHRvIHVzZSBkZXZfcHJpdi0+YWN0aXZl X2NydGNzLCBidXQgdGhhdCB3b24ndCBzYXZlIHlvdSBpZiB5b3UgZW5hYmxlIGludGVycnVwdHMg aW4gYmV0d2VlbiBhdG9taWMgY29tbWl0IGFuZCAuY3J0Y19kaXNhYmxlCj4gPj4+IE5vdGhpbmcg YXRvbWljIGJhc2VkIHdpbGwgd29yayB3ZWxsIGJlY2F1c2UgdGhlIHN0YXRlIGlzIG5vdCBmbGlw cGVkIGF0Cj4gPj4+IHRoZSBzYW1lIHRpbWUgYXMgdGhlIGFjdHVhbCBoYXJkd2FyZSBzdGF0ZSBj aGFuZ2VzLgo+ID4+Pgo+ID4+Pj4gU2FmZXN0IGJldCBpcyB0byBsb29rIGF0IHRoZSBwb3dlciBz dGF0ZSBJIHRoaW5rLgo+ID4+PiBJIGRvbid0IGtub3cgd2hpY2ggcG93ZXIgc3RhdGUgeW91IG1l YW4sIGJ1dCBJIGFscmVhZHkgc2hvdCBkb3duIHRoZQo+ID4+PiBwb3dlciBkb21haW4gdGhpbmcu Cj4gPj4+Cj4gPj4+Cj4gPj4gSSB3b3VsZCBzYXkgdXNlIGFzc2VydF9waXBlX2VuYWJsZWQgdGhl bi4KPiA+IE5vcGUuIFRoYXQgb25lIGZyb2JzIHdpdGggcG93ZXIgZG9tYWlucyB0b28gdGhlc2Ug ZGF5cy4KPiA+Cj4gSSBkb24ndCBzZWUgYSBuaWNlIHdheSB0byBkbyB0aGlzLCBpdCBwcm9iYWJs eSBtZWFucyB3ZSBzaG91bGRuJ3QgZG8gdGhpcyBhdCBhbGwuLgo+IE1heWJlIGhhdmUgYSBmdW5j dGlvbiBsb29rIGF0IGRldl9wcml2LT5wb3dlcl9kb21haW5zLmRvbWFpbl91c2VfY291bnRbW1BP V0VSX0RPTUFJTl9QSVBFKHBpcGUpXSA+PSAxPwo+IEl0J3MgcG90ZW50aWFsbHkgcmFjeSBidXQg SSBkb24ndCBzZWUgYSBuaWNlIHdheSB0byBjaGVjaywgYXBhcnQgZnJvbSBob3Bpbmcgd2UgaGFu ZGxlIHRoZSBkcm0gdmJsYW5rIG9uL29mZgo+IGNhbGxzIGNvcnJlY3RseS4KPiAKPiBUaGUgb25s eSBvdGhlciB3YXkgSSBzZWUgaXMgZGVtaWRsYXllcmluZyB2YmxhbmsuCgpPciBzd2l0Y2ggb3Zl ciBwb3dlciBkb21haW5zIG92ZXIgdG8gdGhlIGNvcmUgcG93ZXIgZG9tYWluIHN0dWZmLiBUaGVy ZSdzCmEgcmVhc29uIHRob3NlIGFyZSBwcm90ZWN0ZWQgd2l0aCBzcGlubG9ja3MsIHNvIHRoYXQg eW91IGNhbiBkbyB0aGVzZQpraW5kcyBvZiBjaGVja3MgOy0pCi1EYW5pZWwKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=