On Thu, Sep 22, 2016 at 01:39:13PM -0400, Trond Myklebust wrote: > If we're replacing an old stateid which has a different 'other' field, > then we probably need to free the old stateid. This gives me a new compiler warning: fs/nfs/nfs4proc.c: In function ‘update_open_stateid’: fs/nfs/nfs4proc.c:1548:2: warning: missing braces around initializer [-Wmissing-braces] nfs4_stateid freeme = {0}; ^ fs/nfs/nfs4proc.c:1548:2: warning: (near initialization for ‘freeme.’) [-Wmissing-braces]