From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 14 Oct 2016 09:07:31 -0400 Subject: [U-Boot] [PATCH] pci: Move CONFIG_PCI_PNP to Kconfig In-Reply-To: References: <1476075874-24615-1-git-send-email-bmeng.cn@gmail.com> <20161012124604.GF4990@bill-the-cat> Message-ID: <20161014130731.GJ31808@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Oct 14, 2016 at 02:28:14PM +0800, Bin Meng wrote: > Hi Tom, > > On Wed, Oct 12, 2016 at 8:46 PM, Tom Rini wrote: > > On Sun, Oct 09, 2016 at 10:04:33PM -0700, Bin Meng wrote: > > > >> Introduce CONFIG_PCI_PNP in Kconfig and move over boards' defconfig > >> to use that. > >> > >> Signed-off-by: Bin Meng > > [snip] > >> 594 files changed, 460 insertions(+), 195 deletions(-) > > [snip] > >> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig > >> index 9a7c187..7fa429b 100644 > >> --- a/drivers/pci/Kconfig > >> +++ b/drivers/pci/Kconfig > >> @@ -18,6 +18,11 @@ config DM_PCI_COMPAT > >> measure when porting a board to use driver model for PCI. Once the > >> board is fully supported, this option should be disabled. > >> > >> +config PCI_PNP > >> + bool "Enable Plug & Play support for PCI" > >> + help > >> + Enable PCI memory and I/O space resource allocation and assignment. > > > > This should be depends on PCI (if all of these options aren't already > > hidden by that, that is) and default y, or default y if ...something. > > Thanks! > > I see some of board configuration header file does not define PCI_PNP > but defined PCI, so it is not a "default y if PCI". I will add a > "depends on PCI || DM_PCI" in v2. Is that OK? It's OK if some platforms that set PCI (or DM_PCI) don't enable PCI_PNP, the aim here is to provide the reasonable default. ie for DISPLAY_BOARDINFO/CPUINFO the default is y for ARM but there's a handful of boards / SoCs that don't provide anything there. But that means we have say 50 files setting it to off rather than 300 files setting it on. So we should still default y this I bet and we'll have a much smaller diffstat than in v1. Thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: